Skip to content

Fixes #1775 interface class extensions added#1776

Merged
MichalLytek merged 5 commits intoMichalLytek:masterfrom
johnsonjo4531:fix-interface-class-extensions-1775
Dec 27, 2025
Merged

Fixes #1775 interface class extensions added#1776
MichalLytek merged 5 commits intoMichalLytek:masterfrom
johnsonjo4531:fix-interface-class-extensions-1775

Conversation

@johnsonjo4531
Copy link
Contributor

Let me know if I can do anything to help get this merged I would appreciate any feedback too.

@MichalLytek
Copy link
Owner

Can you make sure it works when object type extends interface type and when one interface type extends another interface type?

@MichalLytek MichalLytek added Enhancement 🆕 New feature or request Community 👨‍👧 Something initiated by a community labels Mar 4, 2025
@johnsonjo4531
Copy link
Contributor Author

@MichalLytek just made another commit. Are the new test cases what you expected? 😄👍

@johnsonjo4531
Copy link
Contributor Author

Fixes #1775

@johnsonjo4531
Copy link
Contributor Author

Can you make sure it works when object type extends interface type and when one interface type extends another interface type?

By the way I got this request done @MichalLytek in my last commit. Let me know if there is anything I can do more to get this merged. Thank you!

@johnsonjo4531
Copy link
Contributor Author

Hey @MichalLytek, hopefully I'm not being a bother just wondering if this will get merged, or if there is anything I can do to get this merged. It is not a huge blocker for me, because I'm using patch-package to fix the one line change that needs to be made in the code at the moment for my use case, but it may be useful to have it in that actual repo for others that also need that metadata, thanks! 😎👍

johnsonjo4531 and others added 5 commits December 27, 2025 10:25
…alLytek#1775)

These tests will fail without the next upcoming commit which adds extensions into the InterfaceType.
…k#1775)

The tests in extensions.ts from commit 4482b68 will fail without this commit.
… extends interface type related to (MichalLytek#1775)

Made sure the tests and code works when object type extends interface type and when one interface type extends another interface type.
@MichalLytek MichalLytek force-pushed the fix-interface-class-extensions-1775 branch from 72f68ad to 360723f Compare December 27, 2025 09:38
@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.27%. Comparing base (be33fd4) to head (360723f).
⚠️ Report is 87 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
- Coverage   95.50%   95.27%   -0.23%     
==========================================
  Files         113      114       +1     
  Lines        1847     1843       -4     
  Branches      364      357       -7     
==========================================
- Hits         1764     1756       -8     
- Misses         83       87       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MichalLytek MichalLytek merged commit ee2353e into MichalLytek:master Dec 27, 2025
7 of 8 checks passed
@MichalLytek
Copy link
Owner

@johnsonjo4531 Thank you very much for your contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants