Fixes #1775 interface class extensions added#1776
Fixes #1775 interface class extensions added#1776MichalLytek merged 5 commits intoMichalLytek:masterfrom
Conversation
|
Can you make sure it works when object type extends interface type and when one interface type extends another interface type? |
|
@MichalLytek just made another commit. Are the new test cases what you expected? 😄👍 |
|
Fixes #1775 |
By the way I got this request done @MichalLytek in my last commit. Let me know if there is anything I can do more to get this merged. Thank you! |
|
Hey @MichalLytek, hopefully I'm not being a bother just wondering if this will get merged, or if there is anything I can do to get this merged. It is not a huge blocker for me, because I'm using patch-package to fix the one line change that needs to be made in the code at the moment for my use case, but it may be useful to have it in that actual repo for others that also need that metadata, thanks! 😎👍 |
…alLytek#1775) These tests will fail without the next upcoming commit which adds extensions into the InterfaceType.
…mmit fixed stylistic issues (MichalLytek#1775)
… extends interface type related to (MichalLytek#1775) Made sure the tests and code works when object type extends interface type and when one interface type extends another interface type.
72f68ad to
360723f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1776 +/- ##
==========================================
- Coverage 95.50% 95.27% -0.23%
==========================================
Files 113 114 +1
Lines 1847 1843 -4
Branches 364 357 -7
==========================================
- Hits 1764 1756 -8
- Misses 83 87 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@johnsonjo4531 Thank you very much for your contribution! ❤️ |
Let me know if I can do anything to help get this merged I would appreciate any feedback too.