Skip to content

Conversation

@stevegbrooks
Copy link
Contributor

@stevegbrooks stevegbrooks commented Jun 17, 2025

Related issue

Description of changes

The skeleton for azure service was not passing the deployment_id, api_version, or endpoint variables through to ellmer.

To fix this, I added these vars (defined by the users environment vars) in the extras param in gptstudio_request_skeleton.azure_openai, and then grab them with skeleton$extras$extras (R is weird sometimes!) in ellmer_chat.gptstudio_request_azure_openai.

For contributors

  • I have added the relevant changes to the NEWS.md file
  • I have added relevant tests or documentation with my changes

For reviewers

  • Changes meet the acceptance criteria of the related issue
  • The contribution follows style conventions and code of conduct
  • Branch passes automated testing
  • I have incremented the package version in the DESCRIPTION file before merging

@JamesHWade JamesHWade self-assigned this Jun 19, 2025
@JamesHWade
Copy link
Collaborator

Thank you for submitting the PR!

It looks like our skeleton test snapshots are now out of date from your improvements. Those need to be updated before merging. I will have time to do that this weekend, but no need to wait on me if you are familiar with the testthat workflow.

@stevegbrooks
Copy link
Contributor Author

Should be working now - thanks for the reminder to check the tests :)

Copy link
Collaborator

@JamesHWade JamesHWade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for the PR.

@JamesHWade JamesHWade merged commit 7d91bc7 into MichelNivard:main Jun 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: chat app crashes when using Azure OpenAI service

2 participants