Managing multiple src and regex#7
Open
hyptos wants to merge 17 commits into
Open
Conversation
Managing multiple src and added option to remove dest. TODO : writing tests for new use case
Add example
Multiple Src
Added multiple tests and modified other tests
Added multiple definitions and modified other tests
Owner
|
Hello @hyptos, I think that the idea of multiple source files is very good, I just have some concerns about the implementation. I created a branch with a different implementation where Let me know if it works for you and if it does, I'll merge it. |
Author
|
Hi, I'll try it out at work and let you know. I understand your concerns but I had a small time frame to make it work for our use case. Thanks for your work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added some documentation, unit test and the feature that enable the management of multiple src files.
Thanks for your work