Skip to content

Managing multiple src and regex#7

Open
hyptos wants to merge 17 commits into
MicheleBertoli:masterfrom
hyptos:master
Open

Managing multiple src and regex#7
hyptos wants to merge 17 commits into
MicheleBertoli:masterfrom
hyptos:master

Conversation

@hyptos
Copy link
Copy Markdown

@hyptos hyptos commented Mar 30, 2016

Hi,

I added some documentation, unit test and the feature that enable the management of multiple src files.

Thanks for your work

hyptos and others added 9 commits March 30, 2016 09:19
Managing multiple src and added option to remove dest. TODO : writing tests for new use case
Add example
Added multiple tests and modified other tests
Added multiple definitions and modified other tests
@MicheleBertoli
Copy link
Copy Markdown
Owner

Hello @hyptos,
thank you very much for your contribution!

I think that the idea of multiple source files is very good, I just have some concerns about the implementation.
First of all, handling single and multiples sources in two different ways it looks a bit too complex and the test is weak because it doesn't really test the task with multiple files.

I created a branch with a different implementation where dest is used to specify the destination folder.

Let me know if it works for you and if it does, I'll merge it.
Thanks!

@hyptos
Copy link
Copy Markdown
Author

hyptos commented May 1, 2016

Hi,

I'll try it out at work and let you know. I understand your concerns but I had a small time frame to make it work for our use case.

Thanks for your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants