-
Notifications
You must be signed in to change notification settings - Fork 124
Feature/maui/sl popup v2 #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5099fdf
Initial changes based on the rework for Popup
bijington 9b22c64
Popup v2 rework
bijington 03f6e47
Update docs/maui/views/popup/popup-options.md
bijington dd88d83
PopupService improvements
bijington 4859773
Merge branch 'feature/maui/sl-popup-v2' of https://github.com/Microso…
bijington 0b8bb9e
Further improvements
bijington 5cfe8ed
Include new pages in the TOC
bijington 35dffbe
Move note to part of the main text
bijington dcb12b0
Improve the code examples
bijington 8d8ee4a
Add images to docs
bijington a87ce93
PopupService code corrections
bijington b979369
Improvements based on review
bijington eafdfa0
Correct close method name
bijington cb7f271
Remove unused image
bijington 9fc7158
Improve the code readibility
bijington 4dec735
Update docs/maui/views/popup/popup-result.md
bijington 44f1206
Rework based on review comments
bijington ddb7960
Fix validation issues
bijington d1e3fb0
Fix validation issues
bijington f01d65c
Correct path
bijington 49fd8ba
Apply suggestions from code review
bijington d60a4f8
Apply suggestions from code review
bijington 82cb535
Make close examples async
bijington 1f874a8
Merge branch 'main' into feature/maui/sl-popup-v2
jfversluis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.