-
Notifications
You must be signed in to change notification settings - Fork 124
Auto Publish – main to live - 2025-06-11 19:12 (UTC) #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update ParallelHelper.md
```csharp // builder.Services.AddSingleton<IOfflineSpeechToText>(OfflineSpeechToText.Default); ``` The comment currently suggests using `IOfflineSpeechToText` for offline recognition, but that interface doesn’t exist.I checked the sample project, and it looks like `ISpeechToText` is used for both online and offline modes.
* Initial changes based on the rework for Popup * Popup v2 rework * Update docs/maui/views/popup/popup-options.md Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * PopupService improvements * Further improvements * Include new pages in the TOC * Move note to part of the main text * Improve the code examples * Add images to docs * PopupService code corrections * Improvements based on review * Correct close method name * Remove unused image * Improve the code readibility * Update docs/maui/views/popup/popup-result.md Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com> * Rework based on review comments * Fix validation issues * Fix validation issues * Correct path * Apply suggestions from code review Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com> * Make close examples async --------- Co-authored-by: Shaun Lawrence <17139988+bijington@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
Remove Handler disconnect for media element. No longer needed with dotnet 9.x Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
* Add references to Texture View and how to use it. * Update docs/maui/views/MediaElement.md Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com> * Update docs/maui/views/MediaElement.md Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com> * Add codebehind and xaml examples. Provide message about overriding builder and that each media element can be set individually. --------- Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
* Update animation-behavior.md * Update animation-behavior.md --------- Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
…aPreview` and `CameraView.StopCameraPreview` (#553) * Update email-validation-behavior.md * Add .NET Hot Reload Docs * Add C# Examples --------- Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
|
Learn Build status updates of commit 3bac865: 💡 Validation status: suggestionsdocs/maui/views/Popup.md
docs/maui/views/popup/popup-options.md
docs/maui/views/popup/popup-result.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
We should leave this as-is and not merge for now, awaiting further instructions from the docs team. This was created as part of an automated workflow, but failed to merge for some reason. FYI @TheCodeTraveler, thanks for the heads up about the doc sync. I'm working with the docs team to figure out how to re-enable publishing (there's been some changes in this space moving from auto-triggered to nightly chron job). I'm waiting for next steps to see what to do here, as this was supposed to be automatically merge, so need to understand what the proper step to restore state is. In the meantime, be sure to look at the validation suggestions for the future for the image locations. Seems like something we may want to audit across the repo. @alvinashcraft is their guidance on the image stuff somewhere we can reference? The "see documentation" link for the suggestion 404s for me: https://learn.microsoft.com/help/platform/validation-ref/image-structure-incorrect |
|
Merging as per docs team instructions. |
I'm not sure where that link should be going but the page doesn't exist. These are the new rules they recently put in place (on Sunday). They're only Suggestions for existing content but are Warnings for any new content and will impact the content quality score of those articles. I'll send you a link to the Teams channel with a post about this. I'm trying to find where the new rules are all publicly documented. Here's one of the new rules that is documented: https://learn.microsoft.com/en-us/help/platform/validation-ref/filename-contains-stop-word
|
|
I saw on one of our PRs #552 that merged the warning for images not being in the adjacent folder were reported. If these cause a failure to publish then surely they should be errors to prevent a PR from merging? |
|
Suggestions and warnings shouldn't cause a failure to publish, but warnings will impact the content quality scores we use. I was told that they're finding that the new rules for resources being in folders adjacent to files aren't practical for some repos, so I think they may be reconsidering how they enforce those particular rules. |
|
Oh great! We could technically move our images if we needed but it would be great if we don't need to |
This PR was automatically created by Auto Publish system to publish changes from the main branch to the live branch.