Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopilotEmbeddedChatHost changes #801

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

CopilotEmbeddedChatHost changes #801

wants to merge 16 commits into from

Conversation

ShreyasSar26
Copy link
Contributor

Changes in cmdlet to support CopilotEmbeddedChatHost

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit eebee35:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit e68a6a2:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@samkabue
Copy link
Contributor

samkabue commented Feb 6, 2025 •
edited
Loading

SYNTAX

this syntax is incorrect. Please use PlatyPS to get the right syntax. This is what I'm getting for syntax with PlatyPS:

## SYNTAX

Get-SPOApplication [[-OwningApplicationId] <Guid>] [[-ApplicationId] <Guid>] [<CommonParameters>]

Refers to: sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md:19 in e68a6a2. [](commit_id = e68a6a2, deletion_comment = False)

@samkabue
Copy link
Contributor

samkabue commented Feb 6, 2025

SYNTAX

same for the other file

In reply to: 2640685792

Refers to: sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md:19 in e68a6a2. [](commit_id = e68a6a2, deletion_comment = False)

@samkabue samkabue added the Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates label Feb 6, 2025
@samkabue
Copy link
Contributor

samkabue commented Feb 6, 2025

also fix the build issues

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 94b8996:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 15490a5:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 6360a09:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit d19d59e:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit e1823f7:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit eb42241:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit bc2c40f:

💡 Validation status: suggestions

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md 💡Suggestion View (sharepoint-ps) Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'shssaravanan' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@samkabue
Copy link
Contributor

@ShreyasSar26 fix the pending warning

samkabue
samkabue reviewed Feb 21, 2025
View reviewed changes
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md Outdated
@@ -50,7 +60,7 @@ Example 1 returns all SharePoint Embedded applications registered in the specifi
Get-SPOApplication -OwningApplicationId <OwningApplicationId>
```

Example 2 provides details about the owning application in the specified tenant. It returns Applications, which includes the list of guest application IDs with permissions to the owning application, as well as the SharingCapability settings and the OverrideTenantSharingCapability status
Example 2 provides details about the application corresponding to the "Owning Application Id" in the specified tenant. It returns Applications, which includes the list of guest application IDs with permissions to the owning application, as well as the SharingCapability settings, the OverrideTenantSharingCapability status and the list of all Copilot embedded chat host URLs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Owning Application Id"

no quotes, just owning application Id with the right casing

samkabue
samkabue reviewed Feb 21, 2025
View reviewed changes
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md
### Example 4

```powershell
Set-SPOApplication -OwningApplicationId 423poi45 -CopilotEmbeddedChatHosts "http://localhost:3000 https://prepspo.spgrid.com https://pemdevtenant.myownsite.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepspo.spgrid.com

let's not use this example, as this is a real internal tenant. use "contoso" or "fabrikam" in your examples

samkabue
samkabue reviewed Feb 21, 2025
View reviewed changes
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md
### Example 4

```powershell
Set-SPOApplication -OwningApplicationId 423poi45 -CopilotEmbeddedChatHosts "http://localhost:3000 https://prepspo.spgrid.com https://pemdevtenant.myownsite.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pemdevtenant.myownsite.com

use "contoso" or "fabrikam"

dluces
dluces reviewed Feb 21, 2025
View reviewed changes
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md Outdated
@@ -50,7 +60,7 @@ Example 1 returns all SharePoint Embedded applications registered in the specifi
Get-SPOApplication -OwningApplicationId <OwningApplicationId>
```

Example 2 provides details about the owning application in the specified tenant. It returns Applications, which includes the list of guest application IDs with permissions to the owning application, as well as the SharingCapability settings and the OverrideTenantSharingCapability status
Example 2 provides details about the application corresponding to the "Owning Application Id" in the specified tenant. It returns Applications, which includes the list of guest application IDs with permissions to the owning application, as well as the SharingCapability settings, the OverrideTenantSharingCapability status and the list of all Copilot embedded chat host URLs.
Copy link

@dluces dluces Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use the word Copilot with upper-case here as it refers to M365 Copilot and this is not it. Let's use SharePoint Embedded declarative agent experience. Same wording as suggested above.

and all host URLs allowed to use the SharePoint Embedded application's declarative agent experience

dluces
dluces reviewed Feb 21, 2025
View reviewed changes
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md
Get-SPOApplication -OwningApplicationId <OwningApplicationId> | Select-Object CopilotEmbeddedChatHosts
```

Example 4 enumerates the entire list of the host URLs driving the Copilot embedded chat capability on the SharePoint Embedded application.
Copy link

@dluces dluces Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same wording as above

entire list of host URLs allowed to use the SharePoint Embedded application's declarative agent experience

dluces
dluces reviewed Feb 21, 2025
View reviewed changes
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md
Position: Named
Default value: False
Accept pipeline input: False
Accept wildcard characters: False
```
### -CopilotEmbeddedChatHosts

This parameter is used to add host URLs responsible for driving the Copilot embedded chat functionality in the SharePoint Embedded application.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add host URLs allowed to use the SharePoint Embedded application's declarative agent experience.

@gnjoseph gnjoseph mentioned this pull request Feb 21, 2025
Merged
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 073a246:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit d38e5b9:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOApplication.md ✅Succeeded View (sharepoint-ps)
sharepoint/sharepoint-ps/sharepoint-online/Set-SPOApplication.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

@ShreyasSar26 ShreyasSar26 marked this pull request as draft February 22, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dluces dluces dluces left review comments

@samkabue samkabue samkabue left review comments

Assignees

@ShreyasSar26 ShreyasSar26

Labels
Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShreyasSar26 @samkabue @dluces