Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lift-shift-to-containers.md #1998

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update lift-shift-to-containers.md #1998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion virtualization/windowscontainers/quick-start/lift-shift-to-containers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ When validating if the application to be containerized works on Windows containe
|---|---|---|---|
|.NET Framework versions 2.X and 3.X|.NET Framework 4.x|.NET Framework 3.5|Windows Server Core|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this table would benefit from some links to the referenced .NET containers in MAR.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not recommend the 3.5 image - https://github.com/microsoft/dotnet-framework-docker/blob/main/README.runtime.md?

|.NET Framework 4.x versions|.NET Framework 4.x|Build your .NET Framework container image with Server or Windows images|Windows Server Core|
|.NET 6 or 7|.NET 6 or 7 respectively|Build your .NET container image with Windows or Server base images|Windows Nano Server or Server Core|
|.NET 6 or later|Matching .NET container image, for example .NET 9 for .NET 9|Build your .NET container image with Windows or Server base images|Windows Nano Server or Server Core|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example .NET 9 for .NET 9

That phrasing doesn't pop for me. As a user, I'm not quite sure how I'd apply ".NET 9" to containers. Perhaps "9.0" is closer?

I'm not sure this whole table makes much sense. For example, recommending .NET Framework 4.x images for a 2.x/3.x app won't work. That will launch FOD on Windows client, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume yes. I don't feel qualified to update this table more usefully than I have done. Do you or @MichaelSimons want to take a shot?


### Other supporting components

Expand Down