-
Notifications
You must be signed in to change notification settings - Fork 21.8k
Update Azure Web Application Firewall on Application Gateway for Containers #128067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Azure Web Application Firewall on Application Gateway for Containers #128067
Conversation
Mentioned necessary permissions and added common issues.
formatting
|
Learn Build status updates of commit 3669656: ✅ Validation status: passed
For more details, please refer to the build report. |
|
@microsoft-github-policy-service agree |
|
@WolfgangOfner : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 3669656: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Azure Web Application Firewall (WAF) documentation for Application Gateway for Containers by adding critical prerequisites and troubleshooting guidance. The documentation previously lacked essential information that would lead to non-functional WAF policy assignments.
Key changes:
- Added prerequisites section explaining required WAF policy existence and service principal permissions
- Added troubleshooting section with commands to diagnose common deployment issues
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
articles/application-gateway/for-containers/web-application-firewall.md
Outdated
Show resolved
Hide resolved
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
…rewall.md Co-authored-by: Copilot <[email protected]>
|
Learn Build status updates of commit b1fafc6: ✅ Validation status: passed
For more details, please refer to the build report. |
Following the documentation in its current state will lead to a non functional WAF policy assignment. The documentation is missing two key components:
This PR aims to provide more guidance on how to setup everything and what to do in case something went wrong.
Technical details
Assigning an existing WAF policy as described in the documentation will not work. The statue of the deployment is
Falsewhich can be checked withkubectl get WebApplicationFirewallPolicy $WafPolicy -n $InfrastructureNamespace. The state of the WebApplicationFirewallPolicy can be checked withkubectl describe WebApplicationFirewallPolicy $WafPolicy -n $InfrastructureNamespace. In the output, you will see an error message that looks something like: