-
Notifications
You must be signed in to change notification settings - Fork 21.8k
Update Azure Web Application Firewall on Application Gateway for Containers with the Gateway API #128069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added more prerequisites and common issues to help troubleshoot
|
@WolfgangOfner : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 6b6d708:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/application-gateway/for-containers/how-to-waf-gateway-api.md | Details |
articles/application-gateway/for-containers/how-to-waf-gateway-api.md
- Line 35, Column 250: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/cli/azure/network/application-gateway/waf-policy?view=azure-cli-latest' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 35, Column 250: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/cli/azure/network/application-gateway/waf-policy?view=azure-cli-latest' will be broken in isolated environments. Replace with a relative link. - Line 35, Column 250: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/cli/azure/network/application-gateway/waf-policy?view=azure-cli-latest
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
Fixed validation status warnings
|
Learn Build status updates of commit 7f5a24e: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Azure Web Application Firewall documentation for Application Gateway for Containers by adding critical prerequisites and troubleshooting guidance that were previously missing. The changes address a common deployment failure where WAF policies cannot be assigned due to missing permissions or non-existent resources.
- Adds two essential prerequisites: pre-existing WAF policy requirement and ALB Controller identity permissions
- Introduces a new troubleshooting section to help users diagnose and resolve common deployment issues
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
articles/application-gateway/for-containers/how-to-waf-gateway-api.md
Outdated
Show resolved
Hide resolved
articles/application-gateway/for-containers/how-to-waf-gateway-api.md
Outdated
Show resolved
Hide resolved
articles/application-gateway/for-containers/how-to-waf-gateway-api.md
Outdated
Show resolved
Hide resolved
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
…-api.md Co-authored-by: Copilot <[email protected]>
…-api.md Co-authored-by: Copilot <[email protected]>
…-api.md Co-authored-by: Copilot <[email protected]>
|
Learn Build status updates of commit 43fa6cc: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit ea2e84e: ✅ Validation status: passed
For more details, please refer to the build report. |
Following the documentation in its current state will lead to a non functional WAF policy assignment. The documentation is missing two key components:
This PR aims to provide more guidance on how to setup everything and what to do in case something went wrong.
Technical details
Assigning an existing WAF policy as described in the documentation will not work. The statue of the deployment is
Falsewhich can be checked withkubectl get WebApplicationFirewallPolicy $WafPolicy -n $InfrastructureNamespace. The state of the WebApplicationFirewallPolicy can be checked withkubectl describe WebApplicationFirewallPolicy $WafPolicy -n $InfrastructureNamespace. In the output, you will see an error message that looks something like: