Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PodMonitor sample #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

JRBANCEL
Copy link

@JRBANCEL JRBANCEL commented Mar 6, 2025

Based on https://github.com/Azure/prometheus-collector/blob/main/otelcollector/deploy/addon-chart/azure-monitor-metrics-addon/templates/ama-metrics-podmonitor-crd.yaml, namespaceSelector is under spec, not spec.selector.

Error seen currently:

Error from server (BadRequest): error when creating "/home/.../pod-monitor.yaml": PodMonitor in version "v1" cannot be handled as a PodMonitor: strict decoding error: unknown field "spec.selector.namespaceSelector"

Copy link
Contributor

@JRBANCEL : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit e11a3db:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-monitor/containers/prometheus-metrics-scrape-crd.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

@bwren

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Mar 6, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged C+L Pull Request Review Team label azure-monitor/svc Change sent to author containers/subsvc do-not-merge inactive This PR is inactive for more than 14 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants