-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubernetes-monitoring-enable.md #97
base: main
Are you sure you want to change the base?
Conversation
@nyanhp : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 231f449: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
@nyanhp : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
@bwren - Could you review this proposed update to your article and enter |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
The page on AKS Prometheus onboarding should make it clearer that the rule names appear to be mandatory. Setting up the exact same example using the provided code but with our own naming convention led to the cluster not being onboarded fully. I was unable to find documentation elsewhere regarding this behavior. All in all, while the examples are good to have, the explanations could be improved as to why settings have to be as they are.
This PR aims to at least add a note highlighting the required naming pattern for DCE, DCR and DCRA.