Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes-monitoring-enable.md #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nyanhp
Copy link

@nyanhp nyanhp commented Feb 18, 2025

The page on AKS Prometheus onboarding should make it clearer that the rule names appear to be mandatory. Setting up the exact same example using the provided code but with our own naming convention led to the cluster not being onboarded fully. I was unable to find documentation elsewhere regarding this behavior. All in all, while the examples are good to have, the explanations could be improved as to why settings have to be as they are.

This PR aims to at least add a note highlighting the required naming pattern for DCE, DCR and DCRA.

Copy link
Contributor

@nyanhp : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 231f449:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-monitor/containers/kubernetes-monitoring-enable.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Feb 18, 2025

@bwren

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Feb 18, 2025
Copy link

github-actions bot commented Mar 4, 2025

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Mar 4, 2025
@prmerger-automator prmerger-automator bot requested a review from austonli March 4, 2025 18:07
Copy link
Contributor

@nyanhp : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@v-dirichards
Copy link
Contributor

@bwren - Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Mar 5, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants