-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Perf tool overview" article, add missing sections in "Perf reference" #3345
Conversation
microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md
Outdated
Show resolved
Hide resolved
microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md
Outdated
Show resolved
Hide resolved
microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md
Outdated
Show resolved
Hide resolved
microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global in repo: check all links to either article, link to the new Overview article or old Tut article as appropriate.
- New Overview article: [Performance tool: Analyze your website's performance] /evaluate-performance/performance-tool-overview.md
- Old Tut article: [Analyze runtime performance (tutorial)] evaluate-performance/index.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global in article: change links from https://developer.chrome.com/docs/ to local article
@@ -32,46 +32,89 @@ See also: | |||
|
|||
|
|||
<!-- ====================================================================== --> | |||
## Get started | |||
## Open the Performance tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Open the Performance tool | |
## Get started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this old tut article, maybe revert changes; compare & sync this article with recent v129 Chrome tut.
<!-- ====================================================================== --> | ||
## View local and field metrics | ||
|
||
todo: provisionally added new section from https://developer.chrome.com/blog/new-in-devtools-130#live-metrics-recommendations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this old tut article, maybe revert this added h2 section that's probably from Chrome What's New https://developer.chrome.com/blog/new-in-devtools-130#live-metrics-recommendations
Compare & sync this article with recent v129 Chrome tut:
Analyze runtime performance
https://developer.chrome.com/docs/devtools/performance
Learn Build status updates of commit dffa745:
|
File | Status | Preview URL | Details |
---|---|---|---|
microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md | View | Details | |
microsoft-edge/devtools-guide-chromium/about-tools.md | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/capture-settings-icon.png | ✅Succeeded | n/a (file deleted or renamed) | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/capture-settings.png | ✅Succeeded | n/a (file deleted or renamed) | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/perf-home-page.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/capture-settings-icon.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/capture-settings.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/command-menu-performance.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/env-config.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/env-recs.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-advanced-mapping.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-fetched.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-setup.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/get-started-side-by-side.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/observe-metrics.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview.md | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/hide-track-icon.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/move-track-down-icon.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/move-track-up-icon.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/number-hidden-drop-down-arrow.png | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference.md | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/selector-stats.md | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/evaluate-performance/unminify.md | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/experimental-features/index.md | ✅Succeeded | View | |
microsoft-edge/devtools-guide-chromium/overview.md | ✅Succeeded | View |
This comment lists only the first 25 files in the pull request.
microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md
- Line 67, Column 200: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#observe-core-web-vitals-live' in 'devtools-guide-chromium/evaluate-performance/index.md'.
- Line 69, Column 124: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#compare-your-experience-to-the-experience-of-your-users' in 'devtools-guide-chromium/evaluate-performance/index.md'.
- Line 82, Column 76: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#configure-your-environment-to-better-match-that-of-your-users' in 'devtools-guide-chromium/evaluate-performance/index.md'.
- Line 47, Column 4: [Suggestion: duplicate-alt-text - See documentation]
Alt text 'The demo on the left, and DevTools on the right' is duplicated. Within an article, alt text must be unique.
- Line 101, Column 4: [Suggestion: duplicate-alt-text - See documentation]
Alt text 'The demo on the left, and DevTools on the right' is duplicated. Within an article, alt text must be unique.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit 698b983: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Rendered article section for review:
/devtools-guide-chromium/evaluate-performance/index.md
AB#55536961