Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Perf tool overview" article, add missing sections in "Perf reference" #3345

Closed
wants to merge 17 commits into from

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Jan 16, 2025

@mikehoffms mikehoffms added cat: devtools DevTools-related content. in-progress labels Jan 16, 2025
@mikehoffms mikehoffms marked this pull request as ready for review January 28, 2025 03:34
@mikehoffms mikehoffms requested review from Pinkolinka11 and removed request for Pinkolinka11 January 28, 2025 18:46
Copy link

Learn Build status updates of commit fdd5184:

⚠️ Validation status: warnings

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md ⚠️Warning View Details
microsoft-edge/devtools-guide-chromium/about-tools.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/capture-settings-icon.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/capture-settings.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/perf-home-page.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/capture-settings-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/capture-settings.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/command-menu-performance.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/env-config.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/env-recs.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-advanced-mapping.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-fetched.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-setup.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/get-started-side-by-side.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/observe-metrics.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/selector-stats.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/unminify.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/experimental-features/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/overview.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/rendering-tools/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/sample-code/sample-code.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/whats-new/2024/01/devtools-121.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/whats-new/2024/08/devtools-128.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.

microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md

  • Line 67, Column 200: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#observe-core-web-vitals-live' in 'devtools-guide-chromium/evaluate-performance/index.md'.
  • Line 69, Column 124: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#compare-your-experience-to-the-experience-of-your-users' in 'devtools-guide-chromium/evaluate-performance/index.md'.
  • Line 82, Column 76: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#configure-your-environment-to-better-match-that-of-your-users' in 'devtools-guide-chromium/evaluate-performance/index.md'.
  • Line 47, Column 4: [Suggestion: duplicate-alt-text - See documentation] Alt text 'The demo on the left, and DevTools on the right' is duplicated. Within an article, alt text must be unique.
  • Line 101, Column 4: [Suggestion: duplicate-alt-text - See documentation] Alt text 'The demo on the left, and DevTools on the right' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mikehoffms mikehoffms changed the title Perf Home page in "Introduction to the Performance tool" New article "Performance tool: Analyze your website's performance" Feb 13, 2025
Copy link
Collaborator Author

@mikehoffms mikehoffms Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global in repo: check all links to either article, link to the new Overview article or old Tut article as appropriate.

  • New Overview article: [Performance tool: Analyze your website's performance] /evaluate-performance/performance-tool-overview.md
  • Old Tut article: [Analyze runtime performance (tutorial)] evaluate-performance/index.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global in article: change links from https://developer.chrome.com/docs/ to local article

@@ -32,46 +32,89 @@ See also:


<!-- ====================================================================== -->
## Get started
## Open the Performance tool
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Open the Performance tool
## Get started

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this old tut article, maybe revert changes; compare & sync this article with recent v129 Chrome tut.

<!-- ====================================================================== -->
## View local and field metrics

todo: provisionally added new section from https://developer.chrome.com/blog/new-in-devtools-130#live-metrics-recommendations
Copy link
Collaborator Author

@mikehoffms mikehoffms Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this old tut article, maybe revert this added h2 section that's probably from Chrome What's New https://developer.chrome.com/blog/new-in-devtools-130#live-metrics-recommendations
Compare & sync this article with recent v129 Chrome tut:
Analyze runtime performance
https://developer.chrome.com/docs/devtools/performance

Copy link

Learn Build status updates of commit dffa745:

⚠️ Validation status: warnings

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md ⚠️Warning View Details
microsoft-edge/devtools-guide-chromium/about-tools.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/capture-settings-icon.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/capture-settings.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/evaluate-performance/index-images/perf-home-page.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/capture-settings-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/capture-settings.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/command-menu-performance.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/env-config.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/env-recs.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-advanced-mapping.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-fetched.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/field-data-setup.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/get-started-side-by-side.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview-images/observe-metrics.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/performance-tool-overview.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/hide-track-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/move-track-down-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/move-track-up-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference-images/number-hidden-drop-down-arrow.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/reference.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/selector-stats.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/evaluate-performance/unminify.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/experimental-features/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/overview.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.

microsoft-edge/devtools-guide-chromium/evaluate-performance/index.md

  • Line 67, Column 200: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#observe-core-web-vitals-live' in 'devtools-guide-chromium/evaluate-performance/index.md'.
  • Line 69, Column 124: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#compare-your-experience-to-the-experience-of-your-users' in 'devtools-guide-chromium/evaluate-performance/index.md'.
  • Line 82, Column 76: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#configure-your-environment-to-better-match-that-of-your-users' in 'devtools-guide-chromium/evaluate-performance/index.md'.
  • Line 47, Column 4: [Suggestion: duplicate-alt-text - See documentation] Alt text 'The demo on the left, and DevTools on the right' is duplicated. Within an article, alt text must be unique.
  • Line 101, Column 4: [Suggestion: duplicate-alt-text - See documentation] Alt text 'The demo on the left, and DevTools on the right' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mikehoffms mikehoffms changed the title New article "Performance tool: Analyze your website's performance" Add "Perf tool overview" article, add missing sections in "Perf reference" Feb 14, 2025
Copy link

Learn Build status updates of commit 698b983:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 698b983f7b6046c47c2caedaae0172369ceebc18 in branch user/mikehoffms/perf-home of repository https://github.com/MicrosoftDocs/edge-developer into branch main (commit a2efd77ca71938bb401cc75045fddd8ecdeabad0). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mikehoffms mikehoffms closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content. in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants