-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc the Performance tool tab's warning icon when throttled #3350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to also mention the warning icons (for both Performance and Network tools) in these other places:
- https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/network/#simulate-a-slower-network-connection
- https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/network/reference#emulate-slow-network-connections
- https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/evaluate-performance/#simulate-a-mobile-cpu
- https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/evaluate-performance/reference#throttle-the-network-while-recording
- https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/evaluate-performance/reference#throttle-the-cpu-while-recording
Up to you whether we should actually say that the icon appears, or just update surrounding screenshots. I don't think we absolutely need to have a new section in all of these places to say that an icon appears. I just want us to review these other places, and make an informed decision as to whether it makes sense to mention the icon, or update the screenshot.
Rendered article sections for review:
Emulate mobile devices (Device Emulation) > Network and Performance tabs have warning icon when throttled
/devtools-guide-chromium/device-mode/index.md
Introduction to the Performance tool > Simulate a mobile CPU
/devtools-guide-chromium/evaluate-performance/index.md
Performance features reference > Throttle the network while recording & Throttle the CPU while recording
/devtools-guide-chromium/evaluate-performance/reference.md
Inspect network activity > Simulate a slower network connection
/devtools-guide-chromium/network/index.md
Network features reference > Emulate slow network connections
/devtools-guide-chromium/network/reference.md
AB#55537253