Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc the Performance tool tab's warning icon when throttled #3350

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Jan 30, 2025

Rendered article sections for review:

AB#55537253

@mikehoffms mikehoffms added the cat: devtools DevTools-related content. label Jan 30, 2025
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to also mention the warning icons (for both Performance and Network tools) in these other places:

Up to you whether we should actually say that the icon appears, or just update surrounding screenshots. I don't think we absolutely need to have a new section in all of these places to say that an icon appears. I just want us to review these other places, and make an informed decision as to whether it makes sense to mention the icon, or update the screenshot.

@captainbrosset captainbrosset merged commit 81e6ec6 into main Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants