Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebView2 VS Code debugging corrections #3397

Closed
wants to merge 4 commits into from

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Mar 5, 2025

This PR re-applies changes from #3383, which was merged, but apparently overwritten and didn't go through the PR process. Or we might replace the present PR by a fresh PR created by @mikosg which I think is preferable.

Corrections of VS Code launch.json syntax:

  • "useWebView": true property is not allowed for "request": "attach" configs, only for "request": "launch" configs. For attaching configs, useWebView accepts an object instead of a boolean value, where the pipeName property for UWP apps shall be specified, as correctly stated in the UWP section.
  • --remote-debugging-port=9222 command line argument is also needed for "request": "launch" type configs when custom runtimeExecutable is used. It can be supplied either via environment variable or via registry key.

Rendered article sections for review:

AB#56291878

@mikehoffms mikehoffms added in-progress cat: webview2 WebView-related content. labels Mar 5, 2025
@mikehoffms
Copy link
Collaborator Author

mikehoffms commented Mar 5, 2025

I will copy changes from PR #3383
I didn't have a chance to examine that PR. Status will become clear during the present PR.
@mikosg
No ETA. You will be able to enter PR Comments in Files Changed tab, which will add you as reviewer & maybe contributor.


IMO, the following is preferable instead of the present PR:

If you want more credit in GitHub account page or Learn.microsoft.com article, an alternative is we can Close Without Merging the present PR, and you can re-create a fresh PR in your fork of repo. If you create a PR, start from/ base it on the latest, up-to-date pull from "main" branch.

At github in your fork of the edge-developer repo, sync your fork of repo to catch up to upstream "main" branch, similar to this UI for a fork:

image

Before editing a .md file, make sure it's in the expected, latest state, with latest changes per "main" or "live" branch. (Being careful here b/c of previous problem w/ merges.)

Copy link

Learn Build status updates of commit 8ae6f5e:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/how-to/debug-visual-studio-code.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 871d5a2:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/how-to/debug-visual-studio-code.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@mikosg
Copy link
Contributor

mikosg commented Mar 25, 2025

@mikehoffms: I've created another PR for this: #3414.

You can terminate this one.

@mikehoffms
Copy link
Collaborator Author

closing this PR 3397, it is replaced by #3414
@mikosg

@mikehoffms mikehoffms closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content. in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants