-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workaround that's not needed anymore #5259
Conversation
@PesBandi : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit a51de04: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll save this PR for when the update is merged and released. Looks good!
I think this note in the docs is still needed, even after merging mentioned PR , as explained in the discussion starting here microsoft/PowerToys#36735 (comment) TLDR; let's close this PR, do not merge it |
I'd say let's not close it, the docs still need to be updated, since the conditions in which the workaround is needed have changed. I'll let you know when I go through the code again and figure out what to say in the docs. |
Ok. That works. Thank you |
Learn Build status updates of commit 035bce7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@stefansjfw, could you review please |
Looks good. Thank you |
Thanks for updating the PR. I'll merge this when the release goes out. |
After microsoft/PowerToys#36735 is merged, this won't be required anymore.