Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround that's not needed anymore #5259

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

PesBandi
Copy link
Contributor

@PesBandi PesBandi commented Jan 7, 2025

After microsoft/PowerToys#36735 is merged, this won't be required anymore.

Copy link
Contributor

@PesBandi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit a51de04:

✅ Validation status: passed

File Status Preview URL Details
hub/powertoys/run.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@alvinashcraft alvinashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll save this PR for when the update is merged and released. Looks good!

@stefansjfw
Copy link
Contributor

I think this note in the docs is still needed, even after merging mentioned PR , as explained in the discussion starting here microsoft/PowerToys#36735 (comment)

TLDR; let's close this PR, do not merge it

@PesBandi
Copy link
Contributor Author

I'd say let's not close it, the docs still need to be updated, since the conditions in which the workaround is needed have changed. I'll let you know when I go through the code again and figure out what to say in the docs.

@stefansjfw
Copy link
Contributor

I'd say let's not close it, the docs still need to be updated, since the conditions in which the workaround is needed have changed. I'll let you know when I go through the code again and figure out what to say in the docs.

Ok. That works. Thank you

Copy link
Contributor

Learn Build status updates of commit 035bce7:

✅ Validation status: passed

File Status Preview URL Details
hub/powertoys/run.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@PesBandi
Copy link
Contributor Author

@stefansjfw, could you review please

@stefansjfw
Copy link
Contributor

@stefansjfw, could you review please

Looks good. Thank you

@alvinashcraft
Copy link
Contributor

Thanks for updating the PR. I'll merge this when the release goes out.

@PesBandi PesBandi marked this pull request as ready for review February 24, 2025 14:33
@alvinashcraft alvinashcraft merged commit 0b4c4d8 into MicrosoftDocs:docs Mar 5, 2025
2 checks passed
@PesBandi PesBandi deleted the patch-2 branch March 5, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants