Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #841 #840 #839] Expanding sync application examples #851

Conversation

kyerebo
Copy link
Member

@kyerebo kyerebo commented Aug 20, 2024

Expanding upon the description of the sync applications case by adding examples.
Updating navigator.install usage example to match most recent requirements.
Fixes #841, fixes #840, fixes #839

@kyerebo kyerebo changed the title Expanding sync application examples [Issue #841 #840 #839] Expanding sync application examples Aug 20, 2024
Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need to re-think sync'd apps a little bit more.

@HowardWolosky HowardWolosky added the Acquisition Info Enabling store attribution information retrieval for PWAs label Aug 29, 2024
When a synced application is brought over from another device, a `sync` property will be added to keep track of how it was installed.
@dmurph
Copy link

dmurph commented Sep 4, 2024

This fixed the question I had - I'm not an expert on the use-cases here but this seems good?

Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't quite match what we had discussed in the previous iteration...

@kyerebo kyerebo closed this Sep 4, 2024
@kyerebo kyerebo reopened this Sep 4, 2024
@HowardWolosky HowardWolosky merged commit 5cc7492 into MicrosoftEdge:main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acquisition Info Enabling store attribution information retrieval for PWAs
Projects
None yet
3 participants