Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spec for IsWindowControlsOverlayEnabled.md #4613
base: main
Are you sure you want to change the base?
Add Spec for IsWindowControlsOverlayEnabled.md #4613
Changes from all commits
5d6debb
5a4eb5f
4bc0b7a
a4026d9
1714578
b89c178
1221980
8ff7c9e
01a2caf
abbe2c2
fa8e6e5
f3c9cf3
ba722a8
964f28b
cfefaae
12b8134
f34e47c
9790a1e
0390596
3d5d006
2397d9f
c880f4a
b7f2a97
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradp0721 Does it make sense to use raw screen pixels here vs view pixels?
Also, we should ensure that different DPI awareness doesn't create bugs with real raw pixels vs virtual DPI scaled raw pixels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right or left conditional on the reading direction of the UI root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document what happens for RTL locales - does the controls overlay render on the left instead of right?
In the text here say 'before' instead of 'left'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In RTL locales, the caption buttons still appear on the right side of the window, just like in LTR. The ordering of the buttons themselves is mirrored (Close | Maximize | Minimize), but their position remains on the right side of the window.
keeping that in mind 'left' actually fits correctly in the statement? please let me know if you still want it to be 'before' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this text to suggest either using CSS directly or using the event described in here: https://developer.mozilla.org/en-US/docs/Web/API/WindowControlsOverlay#examples
Please also consider adding appropriate HTML/CSS to our sample code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document that it does not support changing the default color or default height for OS theming (dark/light mode and high contrast) and height.