Args by raykpridgen · Pull Request #59 · MigeljanImeri/xdd

raykpridgen · 2026-06-10T08:42:43Z

Issue #58

Initial errors / typos Logic changes New parse function: bytes to suffix Testing Changes Updated documentation

calccrypto · 2026-07-31T21:39:16Z

-    int args, i;
-    int target_number;
+    int args = 0;
+	int  i;


extra space

calccrypto · 2026-07-31T21:42:16Z


 /* The format of the entries in the xdd function table */
-typedef int (*func_ptr)(xdd_plan_t *planp, int32_t argc, char *argv[], uint32_t flags);
+typedef int (*func_ptr)(xdd_plan_t *planp, int32_t argc, char *argv[], uint32_t flags, int32_t target);


add comment saying what return values mean

calccrypto · 2026-07-31T21:46:48Z

-    int args, args_index;
-    int target_number;
+    int args = 0;
+	int  args_index;


extra space

calccrypto · 2026-07-31T21:47:42Z

-    int args, i;
-    int target_number;
+    int args = 0;
+	int  i;


extra space

calccrypto · 2026-07-31T21:48:28Z

-    int 		args, i; // Number of args and a counter
-    int 		target_number; // The specific target number to update
+    int 		args = 0; 			// args
+	int i; 				// counter


calccrypto · 2026-07-31T21:49:02Z

-    int args, i;
-    int target_number;
+    int args = 0;
+	int  i;


extra space

calccrypto · 2026-07-31T21:49:24Z

-    int args, i;
-    int target_number;
+    int args = 0;
+	int  i;


extra space

calccrypto · 2026-07-31T21:49:38Z

+	int 		args = 0;
+	int 		i;
+
 	target_data_t 		*tdp;


calccrypto · 2026-07-31T21:52:24Z

+	int 		args = 0;
+	int 		i;
+
 	target_data_t 		*tdp;
 	int64_t 	numreqs;


align or dont; either way clean these up

calccrypto · 2026-07-31T21:55:26Z

 {
-	int args;
-	int target_number;
+	int args = 0;


is args ever used with a value that is not 0?

calccrypto · 2026-07-31T22:05:47Z

+        finalize_test 1 "${name} crashed on bad grammar (exit ${rc}): $* (see ${log_file})"
+    fi
+}
+


maybe pass in some 0s to make sure you can distinguish between errors and 0 values

calccrypto · 2026-08-05T21:30:21Z

+	else if (strtol(argv[1], NULL, 0) < 0)
+	{
+		fprintf(xgp->errout,
+			"%s: ERROR in '%s': number of targets cannnot be negative: %s\n", xgp->progname, argv[0], argv[1]);
+		return(-1);
 	}

+	// Phase 1
 	if (flags & XDD_PARSE_PHASE1) {
-		k = planp->number_of_targets;  // Keep the current number of targets we have
-		planp->number_of_targets = atoi(argv[1]); // get the number of targets to add to the list
-		if (planp->number_of_targets < 0) { // Set all the target names to the single name specified
-			// Check to see if the target name is actually an "option" - this may be a syntax error on the command line
-			if (*argv[2] == '-') {
-				status = xdd_check_option(argv[2]);
-				if (status != 0) {
-					fprintf(xgp->errout,"%s: syntax error in '%s' specification: target name cannot be an xdd 'option': %s\n",
-						xgp->progname, argv[0], argv[2]);
-					return(-1);
-				}
-			}
-			i = 3; // Set for the return value
-			planp->number_of_targets *= -1; // make this a positive number
-			planp->number_of_targets += k;  // add in the previous number of targets
-			for (j=k; j<planp->number_of_targets; j++) { // This will add targets to the end of the current list of targets
-				// Call xdd_get_target_datap() for each target and put the same target name in each Target Data
-				// Make sure the Target Data for this target exists - if it does not, the xdd_get_target_datap() subroutine will create one
-				tdp = xdd_get_target_datap(planp, j, argv[0]);
-				if (tdp == NULL) return(-1);
-
-				tdp->td_target_basename = argv[2];
-				if (strcmp(tdp->td_target_basename,"null") == 0)
-					tdp->td_target_options |= TO_NULL_TARGET;
-			} // end of FOR loop that places a single target name on each of the associated Target Data
-		} else { // Set all target names to the appropriate name
-			i = 2; // start with the third argument
-			planp->number_of_targets += k;  // add in the previous number of targets
-			for (j=k; j<planp->number_of_targets; j++) { // This will add targets to the end of the current list of targets
-				// Make sure the Target Data for this target exists - if it does not, the xdd_get_target_datap() subroutine will create one
-				tdp = xdd_get_target_datap(planp, j, argv[0]);
-				if (tdp == NULL) return(-1);
-				tdp->td_target_basename = argv[i];
-				if (strcmp(tdp->td_target_basename,"null") == 0)
-					tdp->td_target_options |= TO_NULL_TARGET;
-				i++;
-			}
-		}
-		return(i);
-	} else { // Phase 2 we need to figure out how many targets are specified but not to process them
-		k = atoi(argv[1]); // get the number of targets to add to the list
-		if (k < 0) { // Set all the target names to the single name specified
-			i = 3; // Set for the return value
-		} else { // Set all target names to the appropriate name
-			i = k+2; // start with the third argument
+		k = planp->number_of_targets; // current targets
+		planp->number_of_targets = atoi(argv[1]); // new targets


interesting...

Remove Request Size / reqsize Argument (MigeljanImeri#42)

15a4832

Initial errors / typos Logic changes New parse function: bytes to suffix Testing Changes Updated documentation

raykpridgen force-pushed the args branch from f615cbf to 39e745a Compare June 10, 2026 08:55

raykpridgen force-pushed the args branch 2 times, most recently from 7e61235 to e105312 Compare July 8, 2026 17:49

raykpridgen force-pushed the args branch from e105312 to 8dc6816 Compare July 21, 2026 13:49

raykpridgen added a commit to raykpridgen/xdd that referenced this pull request Jul 22, 2026

Rework Argument Grammar (MigeljanImeri#59)

eb6b481

raykpridgen force-pushed the args branch from 8dc6816 to eb6b481 Compare July 22, 2026 17:54