Improve PostgreSql Authentication #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove problematic _ensure_arrow_table method and its dependencies - Restore direct .arrow() calls without additional materialization wrappers - Remove collections.abc.Iterable and typing.Any imports - Revert all DuckDB 1.4.0 compatibility changes that caused issues This rollback restores the duckdb_backend.py file to commit 5910739, which was the last known working state before the problems started.
…scripts - Updated client.sh to enhance usability and provide clearer connection setup. - Removed client_fixed.py, demo.py, and run_client.py as they are no longer needed. - Improved error handling and configuration loading in client.sh. - Added usage examples and connection configuration display in client.sh. - Simplified command structure and removed unnecessary commands from the client.
- Implemented `execute_sql_file` method in `client.py` to execute SQL commands from a specified file. - Updated command-line interface in `client.sh` to include an option for executing SQL files. - Enhanced error handling and logging during SQL file execution. - Added comprehensive test scripts for schema detection and SQL operations. - Created multiple SQL test files to validate various functionalities including DDL, DML, and analytical queries. - Introduced a new demo script to showcase write and read operations in the DuckLake database.
…s; clean up SQL test files and verification scripts for improved clarity and maintainability.
- Implemented `run_insertsmall_simple.sh` for batch inserts with basic monitoring and error detection. - Introduced `run_quick_schema_test.sh` for rapid validation of schema detection. - Enhanced `client_debug.py` with memory monitoring, error handling, and connection management. - Created SQL test scripts for listing and merging Ducklake files (`01_lakefiles.sql` and `02_lakemergfiles.sql`).
…rsion Co-authored-by: MiguelElGallo <[email protected]>
…reate status report Co-authored-by: MiguelElGallo <[email protected]>
…483-8a89-e37b16bf98ed Prepare test suite for release: Fix all failing tests and improve coverage
- Implement tests for LogfireManager initialization with various token scenarios, including environment variables and explicit parameters. - Validate fallback logger creation and functionality when LogfireManager fails to initialize. - Test public methods of LogfireManager, ensuring proper initialization and logging behavior. - Create tests for convenience logger functions to ensure they call the correct LogfireManager methods. - Add integration tests to verify the complete workflow of logging with both successful and fallback scenarios. - Address edge cases, including handling empty tokens and exceptions in logging methods.
There was a problem hiding this comment.
Pull Request Overview
This pull request improves PostgreSQL authentication by replacing deprecated datetime.utcnow() calls with timezone-aware datetime.now(timezone.utc) throughout the test files and adding proper type annotations. The changes enhance code maintainability and address deprecation warnings while ensuring proper timezone handling.
- Updated timestamp creation to use timezone-aware datetime objects
- Added comprehensive type annotations to test methods and fixtures
- Removed deprecated file that was causing test conflicts
- Added missing return type annotations for better code clarity
Reviewed Changes
Copilot reviewed 70 out of 72 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_transaction.py | Updated to use timezone-aware datetime and added type annotations |
| tests/test_sqlite_backend_comprehensive.py | Added comprehensive type annotations to all test methods |
| tests/test_server.py | Added return type annotations to test methods |
| tests/test_security.py | Updated datetime imports and added type annotations |
| tests/test_phase3_flightsql_methods_fixed.py | Removed deprecated file causing test conflicts |
| tests/test_phase3_flightsql_methods.py.bak | Removed deprecated backup file |
| tests/test_logfire_config.py | Added comprehensive type annotations throughout |
| tests/test_integration_raw_flight_do_put.py | Added type annotations and fixed method signatures |
| tests/test_flightsql_simplified.py | Added return type annotations to all test methods |
| tests/test_flightsql_server_base_comprehensive.py.backup | Removed deprecated backup file |
| tests/test_flightsql_raw_do_put.py | Added type annotations to test methods |
| tests/test_flightsql_protocol_comprehensive.py | Added return type annotations |
| tests/test_flightsql_protobuf_comprehensive.py | Added comprehensive type annotations |
| tests/test_flightsql_protobuf.py | Added return type annotations |
| tests/test_flightsql_minimal_enhanced.py | Added type annotations and removed redundant fixture |
| tests/test_flightsql_minimal_comprehensive.py | Added return type annotations |
| tests/test_flightsql_minimal_basic.py | Added type annotations to test methods |
| tests/test_duckdb_type_conversion.py | Added comprehensive type annotations |
| tests/test_duckdb_backend_improvements.py | Added type annotations and proper generator typing |
| tests/test_duckdb_backend_comprehensive.py | Added helper function and type annotations |
| tests/test_duckdb_backend_arrow_utilities.py | Removed deprecated test file |
| tests/test_duckdb_backend_arrow_methods.py | Added helper function and type annotations |
| tests/test_duckdb_backend.py | Added return type annotations to all test methods |
| tests/test_config.py | Added comprehensive configuration validation tests |
| tests/test_cli.py | Added return type annotations and removed deprecated test methods |
| tests/test_backend_base.py | Added comprehensive backend interface tests |
| tests/test_auth.py | Updated datetime imports and added type annotations |
| test_sql/*.sql | Added comprehensive SQL test files for validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…d improve clarity
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.