Various tweaks/fixes to run python manually on RPi #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the changes I found I had to make when running this on my Raspberry Pi
MiguelNdeCarvalho
requested changes
Jul 3, 2021
Owner
MiguelNdeCarvalho
left a comment
MiguelNdeCarvalho
left a comment
There was a problem hiding this comment.
I have just proposed some things that we could improve in my opinion, but give me yours too :D
| 2. **Enter the repo folder** - `cd speedtest-exporter` | ||
| 3. **Install python modules** - `pip install -r requirements.tx` | ||
| 4. **Execute the exporter** - `python src/exporter.py` | ||
| 3. **Install python modules** - `pip install -r requirements.txt` (or `pip3` if outside a virtual env) |
Owner
There was a problem hiding this comment.
I think here we could only use pip3
| 3. **Install python modules** - `pip install -r requirements.tx` | ||
| 4. **Execute the exporter** - `python src/exporter.py` | ||
| 3. **Install python modules** - `pip install -r requirements.txt` (or `pip3` if outside a virtual env) | ||
| 4. **Execute the exporter** - `python src/exporter.py` (or `python3` if outside a virtual env) |
Owner
There was a problem hiding this comment.
Here we could use only python3 too
| scrape_timeout: 1m | ||
| static_configs: | ||
| - targets: ['speedtest-exporter:9798'] | ||
| - targets: ['localhost:9798'] |
Owner
There was a problem hiding this comment.
Should we explain here, that this localhost is the address from where the exporter is running?
samjewell
commented
Jul 16, 2021
| 2. **Enter the repo folder** - `cd speedtest-exporter` | ||
| 3. **Install python modules** - `pip install -r requirements.tx` | ||
| 4. **Execute the exporter** - `python src/exporter.py` | ||
| 3. **Install python modules** - `pip install -r requirements.txt` (or `pip3` if outside a virtual env) |
Author
There was a problem hiding this comment.
Should include the src/ prefix here too
Suggested change
| 3. **Install python modules** - `pip install -r requirements.txt` (or `pip3` if outside a virtual env) | |
| 3. **Install python modules** - `pip install -r src/requirements.txt` (or `pip3` if outside a virtual env) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes I found I had to make when running this on my Raspberry Pi