HID main protocol alignment, new profiles, strict device init#46
Merged
Conversation
- Extend V2 HID handling (feature/output/input reports, descriptors) and types. - Add Mk.2, Neo, and Plus XL binaries and device configs; Plus/+XL use PID 0x0084 per Elgato docs. - Unify module 15/32 on V2; remove legacy module_15_32 handler. - Replace PID-based device fallback with config::init_runtime_device in each binary entrypoint. - Remove deprecated APIs, unused supervisor/usb/hardware entrypoints, and matrix pin fallbacks. - Refresh protocol reference and CLAUDE.md; drop superseded standalone USB/Mini analysis docs. Made-with: Cursor
This was
linked to
issues
Apr 21, 2026
Closed
- Apply cargo fmt; satisfy clippy type_complexity / too_many_arguments in v2 - PartialWindowChunk + IngestChunkParams for parse_partial_chunk / ingest_chunk - Shared entry and device module cleanup per refactor Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change set aligns the firmware with Elgato’s Main (V2) HID protocol surface, expands supported
Deviceprofiles (Mk.2, Neo, Plus XL, XL 2022, etc.), and removes legacy compatibility paths.Notable behavior changes
0x0084for both, matching the official HID summary table. Layout and unit info differ by build target; firmware selects the variant viaconfig::init_runtime_device(DEVICE)from each binary’smain.init_runtime_devicebefore anything readsget_current_device().ProtocolHandler::create, oldconfigconstants,from_pid/set_device_pid, and silent Mini/matrix fallbacks (unknown layoutspanic).Testing
cargo fmt/cargo check/cargo check --binsThe remote noted the canonical repo may be
MikanseiLaboratory/productiondeck; this PR is opened against theoriginremote used for the push.Made with Cursor