Structured Assigns: better diags - #1927
Open
AndrewNolte wants to merge 3 commits into
Open
Conversation
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Aug 5, 2026
- No more generic 'missing fields' - elaborate which fields - For arrays, specify the type of the array so the user can see which indexes to add, or which type to add - Highlight only first part of struct assign so that the diag doesn't obscure more important diags like syntax errors. stack-info: PR: MikePopoloski#1927, branch: AndrewNolte/stack/27
AndrewNolte
force-pushed
the
AndrewNolte/stack/27
branch
from
August 5, 2026 20:19
fafd5df to
3aeacf5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1927 +/- ##
==========================================
+ Coverage 96.03% 96.06% +0.03%
==========================================
Files 247 247
Lines 56855 56919 +64
==========================================
+ Hits 54599 54681 +82
+ Misses 2256 2238 -18
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
AndrewNolte
marked this pull request as draft
August 6, 2026 04:13
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Aug 6, 2026
- No more generic 'missing fields' - elaborate which fields - For arrays, specify the type of the array so the user can see which indexes to add, or which type to add - Highlight only first part of struct assign so that the diag doesn't obscure more important diags like syntax errors. stack-info: PR: MikePopoloski#1927, branch: AndrewNolte/stack/27
AndrewNolte
force-pushed
the
AndrewNolte/stack/27
branch
from
August 6, 2026 04:13
d8783ec to
31f70f1
Compare
AndrewNolte
marked this pull request as ready for review
August 6, 2026 04:13
AndrewNolte
marked this pull request as draft
August 6, 2026 13:57
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Aug 6, 2026
- No more generic 'missing fields' - elaborate which fields - For arrays, specify the type of the array so the user can see which indexes to add, or which type to add - Highlight only first part of struct assign so that the diag doesn't obscure more important diags like syntax errors. stack-info: PR: MikePopoloski#1927, branch: AndrewNolte/stack/27
AndrewNolte
force-pushed
the
AndrewNolte/stack/27
branch
from
August 6, 2026 13:57
31f70f1 to
738cc8f
Compare
AndrewNolte
marked this pull request as ready for review
August 6, 2026 13:57
AndrewNolte
marked this pull request as draft
August 7, 2026 16:05
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Aug 7, 2026
- No more generic 'missing fields' - elaborate which fields - For arrays, specify the type of the array so the user can see which indexes to add, or which type to add - Highlight only first part of struct assign so that the diag doesn't obscure more important diags like syntax errors. stack-info: PR: MikePopoloski#1927, branch: AndrewNolte/stack/27
AndrewNolte
force-pushed
the
AndrewNolte/stack/27
branch
from
August 7, 2026 16:06
738cc8f to
d79b51c
Compare
AndrewNolte
marked this pull request as ready for review
August 7, 2026 16:06
AndrewNolte
marked this pull request as draft
August 7, 2026 17:14
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Aug 7, 2026
- No more generic 'missing fields' - elaborate which fields - For arrays, specify the type of the array so the user can see which indexes to add, or which type to add - Highlight only first part of struct assign so that the diag doesn't obscure more important diags like syntax errors. stack-info: PR: MikePopoloski#1927, branch: AndrewNolte/stack/27
AndrewNolte
force-pushed
the
AndrewNolte/stack/27
branch
from
August 7, 2026 17:14
d79b51c to
fde8a9d
Compare
AndrewNolte
marked this pull request as ready for review
August 7, 2026 17:14
This puts some more restrictions on notes, many that were already being followed: - Notes cannot have subnotes - Notes cannot be waived, only diags - Note severities can only be remapped to ignored, not errors stack-info: PR: MikePopoloski#1925, branch: AndrewNolte/stack/25
This moves 'Assignment pattern errors' to the be a slang-lit test to show the diag ranges, and make updating expectations easier. It also adds to the test to show some suboptimal diag ranges. stack-info: PR: MikePopoloski#1926, branch: AndrewNolte/stack/26
- No more generic 'missing fields' - elaborate which fields - For arrays, specify the type of the array so the user can see which indexes to add, or which type to add - Highlight only first part of struct assign so that the diag doesn't obscure more important diags like syntax errors. stack-info: PR: MikePopoloski#1927, branch: AndrewNolte/stack/27
AndrewNolte
marked this pull request as draft
August 13, 2026 14:25
AndrewNolte
force-pushed
the
AndrewNolte/stack/27
branch
from
August 13, 2026 14:25
fde8a9d to
fea47b7
Compare
AndrewNolte
marked this pull request as ready for review
August 13, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
View individual changes
Structured Assigns: better diags