Preprocessor: Add synthetic token for trailing disabled branch trivia; - #1928
Open
AndrewNolte wants to merge 1 commit into
Open
Preprocessor: Add synthetic token for trailing disabled branch trivia;#1928AndrewNolte wants to merge 1 commit into
AndrewNolte wants to merge 1 commit into
Conversation
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Aug 6, 2026
This was breaking cst json round trip when ifdefs were present. Added another round trip test for that case. This also puts all of the disabled content back under disabledTokens, which is generally easier to work with. stack-info: PR: MikePopoloski#1928, branch: AndrewNolte/stack/28
AndrewNolte
force-pushed
the
AndrewNolte/stack/28
branch
2 times, most recently
from
August 6, 2026 15:52
02574ca to
0050674
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
- Coverage 96.05% 96.01% -0.05%
==========================================
Files 247 247
Lines 56716 56866 +150
==========================================
+ Hits 54481 54600 +119
- Misses 2235 2266 +31
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Going to clean this up a bit more |
AndrewNolte
marked this pull request as draft
August 6, 2026 21:11
AndrewNolte
added a commit
to AndrewNolte/slang
that referenced
this pull request
Aug 6, 2026
This was breaking cst json round trip when ifdefs were present. Added another round trip test for that case. This also puts all of the disabled content back under disabledTokens, which is generally easier to work with. stack-info: PR: MikePopoloski#1928, branch: AndrewNolte/stack/28
AndrewNolte
force-pushed
the
AndrewNolte/stack/28
branch
from
August 6, 2026 21:11
21a070f to
5df66c0
Compare
AndrewNolte
marked this pull request as ready for review
August 6, 2026 21:11
This was breaking cst json round trip when ifdefs were present. Added another round trip test for that case. This also puts all of the disabled content back under disabledTokens, which is generally easier to work with. stack-info: PR: MikePopoloski#1928, branch: AndrewNolte/stack/28
AndrewNolte
marked this pull request as draft
August 6, 2026 21:13
AndrewNolte
force-pushed
the
AndrewNolte/stack/28
branch
from
August 6, 2026 21:14
add94ca to
2778bf4
Compare
AndrewNolte
marked this pull request as ready for review
August 6, 2026 21:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View individual changes
This was breaking cst json round trip when ifdefs were present.
Added another round trip test for that case.
This also puts all of the disabled content back under disabledTokens, which is generally easier to work with.