Skip to content

Conversation

@w-e-w
Copy link
Contributor

@w-e-w w-e-w commented May 2, 2025

I found that setting these events to not use gradio's queue works better
more responsive and less likely to desync

this is related to several behaviors such as showing / hideing of the controlnet Hires-Fix Option depending on the state of Hires-Fix checkbox

video example

before PR with queue

currently desync can happen if the user quickly clicks the Hires-Fix checkbox multiple times
in the video I demonstrate double clicking it, and can easily result in the a state that Hires-Fix checkbox is check but controlnet Hires-Fix Option is hidden vice versa

2025-05-03.07_35_06_991.chrome.mp4

with PR queue=False

in video I performing the same action repeatedly double clicking Hires-Fix checkbox,
different from before we can see that the Hires-Fix checkbox and show/hide state of controlnet Hires-Fix Option is always in sync

2025-05-03.06_59_27_023.chrome.mp4

also believe that it is faster and more responsive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant