Add abstract types for single- and multi-target MLJ Regressors. #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ressor objects. Right now, SRRegressor and MultitargetSRRegressor subtype AbstractSRRegresor. However, much of the `src/MLJInterface.jl` code dispatches on either SRRegressor or MultitargetSRRegressor. This creates a bottleneck for defining custom MLJInterfaces and forces redefinition of much of `src/MLJInterface.jl`. The commit addresses this by introducing two new types, SingletargetAbstractSRRegressor and MultitargetAbstractSRRegressor, and changes logic in `src/MLJInterface.jl` to dispatch on these types instead. Note: This approach is kind of janky as it solves the reuse problem using multiple inheritence (which might cause problems of its own if abused). This can be trimmed further / I'm open to rethinking this.
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Owner
|
Sounds good to me. One minor thing is it should be |
…l into customize-mlj-interface
Pull Request Test Coverage Report for Build 13093567852Details
💛 - Coveralls |
10 tasks
atharvas
force-pushed
the
customize-mlj-interface
branch
from
3bf5b68 to
e6a502d
Compare
This allows us the SRFitResult struct for LaSR. It shouldn't cause any conflicts with upstream code.
Contributor
Author
|
@MilesCranmer might need your help debugging this. The test case for parametric expressions with the Zygote autodiff seem to be failing even on the SymbolicRegression master branch. |
Owner
|
Sorry for the delay. This turned out to be from an update to DifferentiationInterface.jl which has since been fixed:
Just waiting on a release now. |
MilesCranmer
approved these changes
Feb 1, 2025
Owner
MilesCranmer
left a comment
MilesCranmer
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, SRRegressor and MultitargetSRRegressor subtype AbstractSRRegresor. However, much of the
src/MLJInterface.jlcode dispatches on either SRRegressor or MultitargetSRRegressor. This creates a bottleneck for defining custom MLJInterfaces and forces redefinition of much ofsrc/MLJInterface.jl. The commit addresses this by introducing two new types, SingletargetAbstractSRRegressor and MultitargetAbstractSRRegressor, and changes the logic insrc/MLJInterface.jlto dispatch on these types instead.Note: This approach is kind of janky as it solves the reuse problem using multiple inheritance (which might cause problems of its own if abused). This can be trimmed further / I'm open to rethinking this.