fix: hotfix Zygote backend of DifferentiationInterface #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DifferentiationInterface introduced a change in behavior where the Zygote backend returning
nothingis now an error rather thannothing; this implements a hotfix. It's not a great solution but I'd prefer this over another extension.FYI @gdalle I think the ZygoteNothingError should have been introduced in a breaking release as normally it's common to handle
nothingexplicitly.Though I do think it's the right behavior though overall.Actually changed my mind, I think thenothingshould just be returned.Also would be nice to have ZygoteNothingError defined inside the package itself. If not wanting to put it there, perhaps you could have some trait like:
then I can simply call
e isa nothing_error_type(backend).Or maybe have an abstract type of error for when a gradient isn't defined?