Skip to content

fix: πŸ› code block component can't work for empty language #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Saul-Mirone
Copy link
Member

βœ… Closes: #1293

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Fix empty language for code block component.

How did you test this change?

CI

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
milkdown-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 6, 2024 8:25am

Copy link

nx-cloud bot commented Apr 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 88285df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 3 targets

Sent with πŸ’Œ from NxCloud.

Copy link

cypress bot commented Apr 6, 2024

Passing run #759 β†—οΈŽ

0 83 0 0 Flakiness 0

Details:

Merge 88285df into a07ad0a...
Project: Default Project Commit: 8793446f19 ℹ️
Status: Passed Duration: 01:33 πŸ’‘
Started: Apr 6, 2024 8:28 AM Ended: Apr 6, 2024 8:30 AM

Review all test suite changes for PR #1297 β†—οΈŽ

@Saul-Mirone Saul-Mirone merged commit 5cb26c9 into main Apr 6, 2024
14 checks passed
@Saul-Mirone Saul-Mirone deleted the fix-empty-code-block branch April 6, 2024 08:38
Copy link

cypress bot commented Apr 6, 2024

Passing run #761 β†—οΈŽ

0 83 0 0 Flakiness 0

Details:

fix: πŸ› code block component can't work for empty language (#1297)
Project: Default Project Commit: 5cb26c9803
Status: Passed Duration: 01:45 πŸ’‘
Started: Apr 6, 2024 8:41 AM Ended: Apr 6, 2024 8:43 AM

Review all test suite changes for PR #1297 β†—οΈŽ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Code block can't render content if content was created with no syntax highlighting language chosen
1 participant