Skip to content

fix: πŸ› heading id in readonly mode #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Saul-Mirone
Copy link
Member

βœ… Closes: #1252

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Heading id not synced in readonly mode.

How did you test this change?

CI

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
milkdown-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 6, 2024 8:28am

Copy link

nx-cloud bot commented Apr 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c767dc9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 3 targets

Sent with πŸ’Œ from NxCloud.

Copy link

cypress bot commented Apr 6, 2024

Passing run #760 β†—οΈŽ

0 83 0 0 Flakiness 0

Details:

Merge c767dc9 into a07ad0a...
Project: Default Project Commit: 11083c2c82 ℹ️
Status: Passed Duration: 01:40 πŸ’‘
Started: Apr 6, 2024 8:32 AM Ended: Apr 6, 2024 8:33 AM

Review all test suite changes for PR #1298 β†—οΈŽ

@Saul-Mirone Saul-Mirone merged commit 8f96014 into main Apr 6, 2024
14 checks passed
@Saul-Mirone Saul-Mirone deleted the fix-heading-id-in-readonly branch April 6, 2024 08:38
Copy link

cypress bot commented Apr 6, 2024

Passing run #762 β†—οΈŽ

0 83 0 0 Flakiness 0

Details:

fix: πŸ› heading id in readonly mode (#1298)
Project: Default Project Commit: 8f9601404e
Status: Passed Duration: 01:45 πŸ’‘
Started: Apr 6, 2024 8:42 AM Ended: Apr 6, 2024 8:44 AM

Review all test suite changes for PR #1298 β†—οΈŽ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Heading Id not set in editor readonly mode
1 participant