Skip to content

Fix shift displacement for tooltip plugin #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KBHertzog
Copy link

@KBHertzog KBHertzog commented Apr 11, 2025

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

These changes solve an existing bug where the tooltip (and link tooltip) would position themselves off the page. See here for more information: #1548

How did you test this change?

Here are screenshot of my local development environment. This example uses the link-tooltip plugin as an example. As seen in the linked issue, without the attached changes the tooltip overflows the page. These screenshots show the addition of shift with a static 8px.

Screenshot 2025-04-14 at 4 08 14 PM Screenshot 2025-04-14 at 4 09 14 PM

Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 11afcae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 8:13pm

@Saul-Mirone
Copy link
Member

Let me know when this pr is ready for reviewing :)

@KBHertzog KBHertzog marked this pull request as ready for review April 14, 2025 20:11
@KBHertzog
Copy link
Author

@Saul-Mirone This should be ready. Let me know if you need more extensive testing information. I plan on resolving the merge conflict later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants