Skip to content

feat: 🎸 migrate link tooltip to vue #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

feat: 🎸 migrate link tooltip to vue #1807

merged 1 commit into from
Apr 13, 2025

Conversation

Saul-Mirone
Copy link
Member

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Migrate link tooltip to vue.

How did you test this change?

CI and manually.

Copy link

changeset-bot bot commented Apr 13, 2025

⚠️ No Changeset found

Latest commit: f9a644d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 11:06am

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • packages/crepe/src/theme/common/link-tooltip.css: Language not supported
  • storybook/stories/components/link-tooltip.css: Language not supported
Comments suppressed due to low confidence (2)

packages/crepe/src/feature/shared.ts:8

  • The Icon type has been updated to always return a string instead of string | undefined. Ensure that all icon functions now consistently return a valid string to prevent potential runtime issues.
export type Icon = () => string

packages/components/src/internal/components/icon.tsx:16

  • The Icon component now uses onPointerdown instead of onClick, which triggers earlier in the event lifecycle. Verify that this change aligns with the intended user interaction behavior.
onPointerdown={onClick}

@Saul-Mirone Saul-Mirone added this pull request to the merge queue Apr 13, 2025
Merged via the queue into main with commit f0efe86 Apr 13, 2025
13 checks passed
@Saul-Mirone Saul-Mirone deleted the vue-link-tooltip branch April 13, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant