Merged
Conversation
Contributor
|
ravimeijerrig
force-pushed
the
497-maak-een-test-script-voor-validatie-ook-voor-ci
branch
from
a4565b5 to
2ebd537
Compare
ravimeijerrig
requested review from
Maureenhermeling,
PieterSleutelsBZK,
robbertbos and
uittenbroekrobbert
as code owners
ravimeijerrig
force-pushed
the
497-maak-een-test-script-voor-validatie-ook-voor-ci
branch
from
2d3c4ca to
bc5c95f
Compare
robbertbos
reviewed
May 12, 2025
ravimeijerrig
force-pushed
the
497-maak-een-test-script-voor-validatie-ook-voor-ci
branch
2 times, most recently
from
83214bd to
0d6d370
Compare
ravimeijerrig
force-pushed
the
497-maak-een-test-script-voor-validatie-ook-voor-ci
branch
2 times, most recently
from
03dc072 to
5108f07
Compare
ravimeijerrig
force-pushed
the
497-maak-een-test-script-voor-validatie-ook-voor-ci
branch
from
1ecacc6 to
53cb43b
Compare
This was
unlinked from
issues
May 15, 2025
ravimeijerrig
force-pushed
the
497-maak-een-test-script-voor-validatie-ook-voor-ci
branch
from
c2938bd to
62d0336
Compare
Add validation scripts for URN and lifecycle
ravimeijerrig
force-pushed
the
497-maak-een-test-script-voor-validatie-ook-voor-ci
branch
from
227f41c to
1183029
Compare
robbertbos
reviewed
May 16, 2025
robbertbos
approved these changes
May 16, 2025
ravimeijerrig
deleted the
497-maak-een-test-script-voor-validatie-ook-voor-ci
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beschrijf jouw aanpassingen
Deze PR voegt drie validatiescripts toe die automatisch consistentie binnen het Algoritmekader controleren:
De scripts negeren numerieke voorvoegsels in bestandsnamen en index.md bestanden. Validatie gebeurt zowel via GitHub Actions als pre-commit, waar ook Ruff, whitespace en file-checkers zijn toegevoegd.
Er zijn ook unit-tests voor de validatie scripts toegevoegd. Deze runnen vanuit de ci.
Implementatie
script/validation/.github/workflows/ci.yamlhandled zowel de tests als de validatie zelfscript/validation/run_all_validations.pyBij welk issue hoort deze pull-request?
Checklist before requesting a review