Merged
Conversation
Redesign MOZa Weekly Toevoegen dark mode voor Rijksoverheid
|
Introductie hero layout en refactor home
Collaborator
|
Gekeken samen met @RobinAlderliesten @rnacken Functionele dingen:
Technische dingetjes:
|
Member
Author
|
@AmbtenaarInFunctie @RobinAlderliesten @rnacken dank dat jullie hier naar gekeken hebben. Wat voor mij belangrijk is, is dat we straks met een bredere groep aan onze site kunnen werken. Dat gaat dan niet alleen om het toevoegen van een MOZa Weekly, maar bijv. ook om het toevoegen van een nieuw onderwerp of een bestand dat we willen delen. Ik denk dat de opzet met Hugo dat makkelijker maakt t.o.v. de opzet nu met React.
M.b.t. technische dingetjes:
|
Rename $toc to $tocScript for the JS resource to avoid shadowing the TableOfContents variable, improving code clarity
The checkout step was skipped when a PR was closed, causing the preview cleanup action to fail with "not in a git directory" error.
This reverts commit 6da1e30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.