refactor: move zkApp version inline test to Alcotest #18209
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the `let%test "latest zkApp version"` inline test from zkapp_command.ml to zkapp_command_test.ml as an Alcotest test. This improves test discoverability and consistency with other tests in the mina_base test suite.
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-bypass-changelog |
Member
Author
|
This PR has to be replicated on the develop branch, as the version has been updated: https://github.com/MinaProtocol/mina/blob/develop/src/lib/mina_base/zkapp_command.ml#L1483. |
glyh
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
let%test "latest zkApp version"inline test from zkapp_command.ml to zkapp_command_test.ml as an Alcotest test.This improves test discoverability and consistency with other tests in the mina_base test suite.
Cherry-picked from #18203