Document verifier library #18210
Open
Document verifier library #18210
+118
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/document-verifier-module
branch
from
af3fcde to
f2e6739
Compare
Member
Author
|
!ci-bypass-changelog |
Member
Author
|
!ci-build-me |
glyh
reviewed
Dec 8, 2025
src/lib/verifier/verifier_intf.ml
Outdated
| - [`Valid_assuming proofs]: Signatures valid, proofs need async verification | ||
| - [invalid]: Verification failed | ||
| The outer [Or_error.t] represents communication failure with verifier process. *) |
Member
Author
There was a problem hiding this comment.
I think it will be better to remove this comment. The set of errors that can be returned is not trivial.
glyh
reviewed
Dec 8, 2025
| module Base = struct | ||
| module type S = sig | ||
| type t | ||
| (** The verifier instance. *) |
Member
There was a problem hiding this comment.
I'm not a fan of documents that are basically repeating the code.
Verifier.mli: - Module purpose (transaction and SNARK verification) - Usage locations (transaction pool, staged ledger, mina lib, snark profiler) - Verification types (commands, blockchain SNARKs, transaction SNARKs) - Implementations (Prod, Dummy) - Common module functions (check_signatures_of_zkapp_command, check_signed_command) - Document Rpc_parallel process structure (Worker.T, spawn, connection) - Document daemon integration (created in Mina_lib, passed to components) Mina_lib.mli: - Document subprocesses spawned by create: Prover, Verifier, VRF evaluator - Document components initialized: Transaction_pool, Snark_pool, etc.
dannywillems
force-pushed
the
dw/document-verifier-module
branch
from
f2e6739 to
2336e22
Compare
Document: - Module purpose (Base.S vs S) - All invalid variants with their meanings - verify_commands return values - verify_blockchain_snarks, verify_transaction_snarks - create function parameters
dannywillems
force-pushed
the
dw/document-verifier-module
branch
from
2336e22 to
250885a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit history.
Use
dune build @doc --only-packages=verifierto build the doc.The doc is available under
_build/default/_doc/_html/verifier/index.html.Will be useful for o1-labs/mina-rust#1759