Skip to content

Conversation

@Shigoto-dev19
Copy link

@Shigoto-dev19 Shigoto-dev19 commented Dec 8, 2025

Closes o1-labs/o1js#2521

proof-systems side: o1-labs/proof-systems#3383
o1js side: o1-labs/o1js#2675

var ww = new w.WasmVecVecFp(witness_cols.length - 1)
for (var i = 1; i < witness_cols.length; i++) {
w.push(tsRustConversionNative.fp.vectorToRust(witness_cols[i]));
ww.push(tsRustConversionNative.fp.vectorToRust(witness_cols[i]));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird because the first w return the whole plonk_wasm "napi" module and so the compiler throws an error and the ww return the actual WasmVecVecFp instantiation we need 👀

var caml_pasta_fq_plonk_proof_batch_verify = function (indexes, proofs) {
indexes = tsRustConversionNative.mapMlArrayToRustVector(
indexes,
tsRustConversionNatsRustConversionNativetive.fq.verifierIndexToRust
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo here

@Shigoto-dev19 Shigoto-dev19 changed the base branch from querolita/napi-proof to querolita/napi-vindex December 8, 2025 00:58
@Shigoto-dev19 Shigoto-dev19 marked this pull request as ready for review December 8, 2025 00:58
@Shigoto-dev19 Shigoto-dev19 requested a review from a team as a code owner December 8, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants