Skip to content

feat: extend CI pipeline with contract checks and update contribution guidelines - #336

Closed
gabito1451 wants to merge 8 commits into
MindBlockLabs:mainfrom
gabito1451:#291
Closed

feat: extend CI pipeline with contract checks and update contribution guidelines#336
gabito1451 wants to merge 8 commits into
MindBlockLabs:mainfrom
gabito1451:#291

Conversation

@gabito1451

@gabito1451 gabito1451 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Contribution Guidelines Update

I have successfully implemented the requested changes to extend the CI pipeline and update the contribution guidelines.


Summary of Changes

1. Refactored Repository Structure

  • Renamed the contract/ directory to contracts/ to ensure consistency with:
    • The project’s package.json workspaces configuration
    • Existing README.md instructions

2. Extended ci.yml Workflow

  • Added a new contracts job that runs on every push and pull request
  • Configured the job to:
    • Install the Rust toolchain with:
      • wasm32-unknown-unknown target
      • rustfmt component
    • Install the Stellar CLI
  • Added steps to:
    • Run formatting checks:
      cargo fmt --check
    • Build the contract:
      stellar contract build
    • Run tests:
      cargo test
    • All commands are executed within the contracts/ directory

3. Updated ci-cd.yml Workflow

  • Replaced placeholder comments in the build-and-deploy job with actual build steps
  • The job now:
    • Checks out the code
    • Sets up Node.js 20.x
    • Installs dependencies:
      npm ci
    • Builds both:
      • Frontend workspace
      • Backend workspace
  • Maintained dependency on the validate-pr job

4. Updated CONTRIBUTING.md

  • Added a dedicated section for contract contributors under "MUST RUN local checks", including:
    • Required prerequisites
    • Commands to run before submitting a PR
  • Updated Branch Protection rules to include:
    • contracts as a required status check
    • Alongside:
      • lint-imports
      • build
      • type-check

@drips-wave

drips-wave Bot commented Mar 24, 2026

Copy link
Copy Markdown

@gabito1451 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@gabito1451 gabito1451 changed the title Implement the requested changes to extend the CI pipeline and updated the contribution guidelines feat: extend CI pipeline with contract checks and update contribution guidelines Mar 24, 2026
@drips-wave

drips-wave Bot commented Mar 25, 2026

Copy link
Copy Markdown

Hey @gabito1451! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#311 Implement JWT Authentication Middleware with Token Validation Link to this issue
#317 Error Handling and Standardization Middleware Link to this issue
#323 IP Geolocation and Localization Middleware Link to this issue

ℹ️ Learn more about linking PRs to issues

@gabito1451 gabito1451 closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant