Add unit tests for onboarding funnel provider - #581
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Tinna23
force-pushed
the
issue/561-funnel-tests
branch
from
July 21, 2026 10:06
b3120e5 to
3796966
Compare
Write unit tests for GetOnboardingFunnelProvider covering the happy path with all 5 funnel stages, an empty-data edge case where all counts are zero, and a boundary date-range filtering case. Repositories are mocked with no real DB connection required. Closes MindBlockLabs#561
Tinna23
force-pushed
the
issue/561-funnel-tests
branch
from
July 21, 2026 10:08
3796966 to
0c793be
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Write unit tests for
GetOnboardingFunnelProvidercovering the happy path, an empty-data edge case, and a boundary date-range case, using mocked repositories.Changes
GetOnboardingFunnelProviderimplementationget-onboarding-funnel.provider.spec.tswith 3 test casesFunnelResultandFunnelStageinterfacesAcceptance Criteria
npm testwith no manual setupCloses #561