Skip to content

feat: separate xp and score rewards - #632

Merged
phertyameen merged 11 commits into
MindBlockLabs:mainfrom
kiel997:feature/separate-xp-score-rewards
Aug 20, 2026
Merged

feat: separate xp and score rewards#632
phertyameen merged 11 commits into
MindBlockLabs:mainfrom
kiel997:feature/separate-xp-score-rewards

Conversation

@kiel997

@kiel997 kiel997 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

closes #617

Summary

Separates XP, score, and blockchain reward responsibilities in the Mind Block backend.

Changes

  • Added ScoreService for independent score calculation.
  • Added RewardService for independent reward eligibility calculation.
  • Reused the existing XpLevelService for player progression.
  • Updated progress calculation to use ScoreService.
  • Removed direct XP/level mutation from the progress calculation flow.
  • Routed daily quest bonus XP through XpLevelService.
  • Kept blockchain interaction isolated from score and reward eligibility calculations.
  • Added unit tests for score calculation.
  • Added unit tests for reward eligibility.

Architecture

Correct Answer

Score

XP

Reward Eligibility

Blockchain Reward

Testing

  • npm test -- --runInBand
  • All existing tests pass.
  • ScoreService tests pass.
  • RewardService tests pass.

Acceptance Criteria

  • XP is calculated independently.
  • Score is calculated independently.
  • Reward eligibility is calculated independently.
  • Blockchain interaction is isolated behind a service.
  • Puzzle validation does not directly depend on blockchain availability.
  • Tests exist for score and reward calculations.

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

@kiel997 is attempting to deploy a commit to the aminubabafatima8-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
mind-block-app-frontend Skipped Skipped Aug 20, 2026 2:16am

@kiel997 kiel997 changed the title Feature/separate xp score rewards feat: separate xp and score rewards Aug 20, 2026
@phertyameen
phertyameen merged commit 94c5b50 into MindBlockLabs:main Aug 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate XP, Score and Blockchain Rewards

2 participants