-
Notifications
You must be signed in to change notification settings - Fork 0
[ALFMOB-81] Add to Bag #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrfreitas
wants to merge
20
commits into
main
Choose a base branch
from
dev/ALFMOB-81_add_to_bag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/src/main/java/au/com/alfie/ecomm/feature/mappers/MapPrice.kt
Outdated
Show resolved
Hide resolved
feature/src/main/java/au/com/alfie/ecomm/feature/mappers/MapImage.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/test/java/au/com/alfie/ecomm/feature/bag/BagViewModelTest.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/test/java/au/com/alfie/ecomm/feature/bag/BagViewModelTest.kt
Outdated
Show resolved
Hide resolved
feature/pdp/src/main/java/au/com/alfie/ecomm/feature/pdp/ProductDetailsScreen.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagScreen.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagUiState.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagUiState.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/models/BagProductUi.kt
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagViewModel.kt
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagUiState.kt
Outdated
Show resolved
Hide resolved
feature/pdp/src/main/java/au/com/alfie/ecomm/feature/pdp/ProductDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/au/com/alfie/ecomm/domain/bag/AddToBagUseCaseTest.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagUiFactory.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagUiFactory.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/au/com/alfie/ecomm/domain/usecase/bag/AddToBagUseCase.kt
Outdated
Show resolved
Hide resolved
domain/repository/src/main/java/au/com/alfie/ecomm/repository/bag/BagRepository.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # feature/plp/src/main/java/au/com/alfie/ecomm/feature/plp/factory/ProductListEntryUIFactory.kt
pmac8585
requested changes
Feb 19, 2025
data/src/main/java/au/com/alfie/ecomm/data/bag/BagRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
...ystem/src/main/java/au/com/alfie/ecomm/designsystem/component/productcard/ProductCardType.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/au/com/alfie/ecomm/domain/usecase/bag/AddToBagUseCase.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagUiFactory.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagUiState.kt
Outdated
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagViewModel.kt
Outdated
Show resolved
Hide resolved
feature/pdp/src/main/java/au/com/alfie/ecomm/feature/pdp/ProductDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
feature/pdp/src/test/java/au/com/alfie/ecomm/feature/pdp/ProductDetailsViewModelTest.kt
Show resolved
Hide resolved
feature/bag/src/main/java/au/com/alfie/ecomm/feature/bag/BagScreen.kt
Outdated
Show resolved
Hide resolved
pmac8585
approved these changes
Mar 17, 2025
rsousamindera
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add product to bag using the button add to bag on product detail
This is implemented using only an im memory cache, basically it is matching what IOS have.
Some TODO were added to change it latter to use DB or api to proper save the items.
Also the list for the bag scree was implemented, again it was implemented to match IOS and have feature parity.
