Merged
Conversation
Contributor
|
Merging before #8, so that I can make the required adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf: #5 refactor config props
Description 📝
The main idea of a "config prop" is to facilitate parsing either from arguments or env variables (and in the future from a config dot file as well).
ConfigPropsclass is now converted into theConfigPropclass, and static consts for each of the config properties (app id, token and api-key) are now individualConfigPropconst instances.You can obtain the value (either from args or env-vars) calling like:
Type of change
Updates
ConfigPropsandEnvironmentto support this change.ConfigPropsoriginallyTest plan 🧪
Tested some commands to verify everything works as before:
Also updated unit tests.
Author to check 👓
Reviewer to check ✔️