Add a bundle that excludes the web-vitals vendor scripts#411
Open
samuel-holt wants to merge 2 commits intomasterfrom
Open
Add a bundle that excludes the web-vitals vendor scripts#411samuel-holt wants to merge 2 commits intomasterfrom
samuel-holt wants to merge 2 commits intomasterfrom
Conversation
JasenPalmer
approved these changes
Jun 15, 2021
Contributor
JasenPalmer
left a comment
There was a problem hiding this comment.
Thanks for making this change. Looks good to me
JasenPalmer
approved these changes
Jun 15, 2021
mduncan26
approved these changes
Jun 15, 2021
Contributor
mduncan26
left a comment
There was a problem hiding this comment.
Looks good but to be honest raygun4js isnt where my expertise lies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Developers may want to include the web-vitals base and polyfill scripts themselves due to environmental reasons* or to have better control over how the polyfill script is loaded (see the How to use the polyfill section for more details).
*There is a use of Set and WeakSet in the library that can cause issues when trying to support legacy browsers (e.g. older than IE11).
Updates
Example usage