Delayed boot until after Raygun has Initialised#518
Open
Hamish-taylor wants to merge 1 commit intomasterfrom
Open
Delayed boot until after Raygun has Initialised#518Hamish-taylor wants to merge 1 commit intomasterfrom
Hamish-taylor wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Commands like rg4js("apikey",..) and rg4js("options",..) are only applied while raygun4js is initializing, after initialization if one is called by a user nothing occurs. To apply these settings a user can call rg4js("boot") which will re run the initialization, applying the new settings.
The issue
When raygun4js is initializing it processes all of the commands that have been sent so far, if one of them is boot, it will cause the initialization to be called again which will subsequently process the boot command again causing an infinite loop.
The fix
There are a few ways this could be fixed, the easiest being to ignore any calls to boot during the initialization, this may create confusion because boot will not be operating as expected, however, this may be preferable to an infinite loop that crashes the app