[1.21.10] Provide LevelRenderState during frame pass construction (#10867) #10688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoforge
bot
added
Triage
|
The code looks good. Though I am now fully traumatized by the Thanks also for adding Javadocs. They'll be useful when looking back on the codebase to update the actual documentation website. |
LexManos
reviewed
Oct 21, 2025
LexManos
reviewed
Oct 21, 2025
LexManos
reviewed
Oct 21, 2025
Fealtous
force-pushed
the
1.21.x-provide-levelrenderstate
branch
from
40b5622 to
e45b1aa
Compare
autoforge
bot
added
the
Needs Rebase
|
@Fealtous, this pull request has conflicts, please resolve them for this PR to move forward. |
Fealtous
force-pushed
the
1.21.x-provide-levelrenderstate
branch
from
e45b1aa to
5a6359f
Compare
autoforge
bot
removed
the
Needs Rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test(s) still work fine. There may be other work needed if modders need extra render context but at the moment this seems enough, at least until someone can provide a concrete example where extra details are needed.
