dragonhyeon: changed fixed z noise map implementation details#1
Open
dragonHyeon wants to merge 1 commit into
Open
dragonhyeon: changed fixed z noise map implementation details#1dragonHyeon wants to merge 1 commit into
dragonHyeon wants to merge 1 commit into
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. Thank you for your contribution. Your code helped me a lot understanding SinGAN. I've changed part of your code.
I think using z_rec as a fixed_Zs[0] (which denoted as z* in paper) might be a better choice rather than just normal z. Also it seems more reasonable to use zero tensors as fixed_Zs[1:] rather than normal z since they use 0 as fixed noise in paper. (though there's no problem running your code since they have been just used to purpose of getting the shape of tensors.)
If you think it's reasonable I hope you merge my code. Once again, thanks for your readable, scalable code!