Skip to content

Conversation

@BenCheung0422
Copy link
Member

@BenCheung0422 BenCheung0422 commented Jul 10, 2023

This depends on #534
From #521
This adds a new furniture, Repair Bench, made from early materials; costs raw materials of tools to repair tools; allows repairing more common items, i.e. fishing rod items.

@BenCheung0422
Copy link
Member Author

Should we make armors repairable?

@BenCheung0422 BenCheung0422 changed the title Add Dark Anvil Add Dark Anvil and Repair Bench Jul 11, 2023
@Makkkkus
Copy link
Member

Makkkkus commented Jul 13, 2023

You can't include commits from other pull requests in this pull request. I have already told you this...

We also can't have both of these. I thought I made it pretty clear that we won't add new items/entities.

@BenCheung0422
Copy link
Member Author

BenCheung0422 commented Jul 13, 2023

This is the better way to implement repairing. We can not implement tool repair without any addition.

@Makkkkus
Copy link
Member

Remove the Dark Anvil.

@BenCheung0422
Copy link
Member Author

BenCheung0422 commented Jul 14, 2023

Is it good to have ability to break down tools back to their raw materials and ability to repair armors?
Dark Anvil is removed.

@BenCheung0422 BenCheung0422 changed the title Add Dark Anvil and Repair Bench Add Repair Bench Jul 15, 2023
@Litorom
Copy link
Member

Litorom commented Jan 25, 2024

I would like it possible to have repairable armor, but that requires the armor system to be renovated

# Conflicts:
#	src/client/java/minicraft/item/FishingRodItem.java
#	src/client/java/minicraft/item/FurnitureItem.java
#	src/client/java/minicraft/item/Recipes.java
#	src/client/java/minicraft/item/ToolItem.java
#	src/client/java/minicraft/saveload/Load.java
#	src/client/java/minicraft/screen/Menu.java
# Conflicts:
#	src/client/java/minicraft/saveload/Load.java
#	src/client/java/minicraft/util/MyUtils.java
@Makkkkus
Copy link
Member

Makkkkus commented Jun 3, 2025

This is a good addition to the game, but I still don't see the need for the dark anvil. I see it's still in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants