Add sign #548
Merged
Add sign #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristofferHolmesland
previously approved these changes
Aug 16, 2023
Member
|
Could you please resolve conflicts. I believe this can work with storyline. |
# Conflicts: # src/client/java/minicraft/core/io/InputHandler.java # src/client/java/minicraft/item/Items.java # src/client/java/minicraft/level/Level.java # src/client/java/minicraft/level/tile/Tiles.java # src/client/java/minicraft/level/tile/TorchTile.java
Member
Author
|
Conflicts are now resolved. |
Litorom
requested changes
Feb 8, 2024
Member
Litorom
left a comment
Litorom
left a comment
There was a problem hiding this comment.
Sign display still shows sometimes after leaving a sign tile.
Member
Author
|
It should be fixed now. |
Litorom
requested changes
Feb 12, 2024
Member
Litorom
left a comment
Litorom
left a comment
There was a problem hiding this comment.
Upon editing the sign in creative, you can use Debug cmds and switch levels when in sign edit menu
Member
Author
|
Okay, actually that happens to every menu, even pause menu. |
Member
Author
|
In this case, #504 should have already avoided this from happening. |
Litorom
requested changes
Feb 25, 2024
Member
Litorom
left a comment
Litorom
left a comment
There was a problem hiding this comment.
This is not what I meant! Please change it back and add menu checks
Member
Author
|
Okay I added it back and moved to another place. |
Member
Author
|
The code will be updated based on #555. |
# Conflicts: # src/client/java/minicraft/level/Level.java # src/client/java/minicraft/level/tile/Tiles.java # src/client/java/minicraft/level/tile/TorchTile.java # src/client/java/minicraft/saveload/Load.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #351
The original pull request doing this is #366 and has been closed because of the incompatibility of the tile handling system.
Currently, there is a way do that by adding a separated save file for signs, but it still needs to be combined into a standardized system of tile data save system in the future. Signs could make more contents within structures when complementing the storyline. As mentioned in #542, tile entities could be made with signs.