Improved supports for in-app/game notifications and toasts #587

BenCheung0422 · 2023-11-15T10:59:31Z

This feature is reserved for future use. This adds a support for in-app notifications, where toasts in the screen. It is different from in-game notifications, bare text only, as this includes a frame, and the color can be changed. This is important when there are some alerts, warnings and important information needed to notify the users.

I have several ideas about box popups and notifications: (fading is not supported right now)

Toast notifications (slide in slide out) - quick informative notification (near top-right/bottom-right corner sliding on side)
Bottom slide popup (slide in slide out) - app tool bar? But currently there is no such possible uses. (near bottom-right corner sliding on bottom)

Position for toasts may be configurable to upper or lower positions (also for each type of toast notification?).

Additionally, achievement unlocking toast is added to replace the text-only notifications regarding unlocking achievements. (https://discord.com/channels/280723930942013440/1141498209634623539)
This improves visual quality of life.

BenCheung0422 · 2023-12-30T18:26:28Z

Demo from #588:

Minicraft.Plus.2023-12-31.02-24-16.-.Trim.mp4

Makkkkus · 2024-01-07T19:19:29Z

In-app notifications are usually a result of bad game design. Using this will make the game feel more like a cheap mobile game than an free and open-source sandbox game. Perhaps an icon can be showed insted when a controller is plugged in?

# Conflicts: # src/client/java/minicraft/item/FishingRodItem.java # src/client/java/minicraft/item/SummonItem.java # src/client/java/minicraft/screen/AchievementsDisplay.java

BenCheung0422 · 2024-02-09T03:50:46Z

New design for toast notifications

Minicraft.Plus.2024-02-09.11-48-17.mp4

BenCheung0422 · 2024-02-09T09:34:32Z

App status top bar (shows automatically for 2 seconds on startup and shown when "9" (~~I was seeking to use symbols but it seems like they are not supported, which is not right~~Actually it is possible, but with different wordings) is down)

Minicraft.Plus.2024-02-09.17-32-31.mp4

BenCheung0422 · 2024-02-09T11:49:18Z

The new achievement unlocking toast, replacing the original text-only notification.

Minicraft.Plus.2024-02-09.19-37-49.mp4

BenCheung0422 · 2024-02-09T11:53:12Z

Updates has been made for this pull request regarding the issues and it is now ready for review again.

Makkkkus

The new changes look great!

Although, app toast and game toast should be merged to just be game toast. Having two is unneccecary.

BenCheung0422 · 2024-02-13T10:29:16Z

Ok, it is removed.

Litorom · 2024-06-25T00:14:21Z

Can you update this please.

# Conflicts: # src/client/java/minicraft/core/Renderer.java # src/client/java/minicraft/screen/TutorialDisplayHandler.java

BenCheung0422 · 2024-06-25T04:28:23Z

Okay, branch updated.

# Conflicts: # src/client/java/minicraft/entity/furniture/DeathChest.java

Makkkkus · 2025-06-03T13:06:52Z

This is a good addition to the game, but I still think that app toasts and game toasts should be merged. I don't see how they are substantially different.

Also, are you still working on this?

BenCheung0422 · 2025-06-03T13:19:31Z

I could still fix minor things for my pull requests on this repository, or else they could be closed.

Makkkkus · 2025-06-03T13:20:54Z

I think at least this PR should be merged

Makkkkus

I still have some problems I wish you would adress.

src/client/java/minicraft/core/Game.java

src/client/java/minicraft/core/Renderer.java

src/client/java/minicraft/core/Updater.java

src/client/java/minicraft/screen/AchievementsDisplay.java

src/client/java/minicraft/screen/AppToast.java

Copilot

Pull Request Overview

This PR enhances in-app notifications by introducing a new toast system with configurable positioning and upgraded visual styles, and it replaces the legacy notifications with in-game notifications.

Introduces AppToast with several frame implementations and configurable top/bottom positioning.
Implements AchievementUnlockToast for achievement notifications, replacing text-only alerts.
Updates various game logic files to use inGameNotifications and integrates toast management in the core update and render flows.

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/client/java/minicraft/screen/AppToast.java	New toast implementation supporting multiple frame styles and configurable positioning.
src/client/java/minicraft/screen/AchievementsDisplay.java	Added AchievementUnlockToast and updated achievement notification logic.
src/client/java/minicraft/level/tile/*.java	Replaced legacy notifications with inGameNotifications across wall, boss, and rock tiles.
src/client/java/minicraft/item/*.java	Updated notification calls in item interactions to use inGameNotifications.
src/client/java/minicraft/core/Updater.java, Renderer.java, Game.java	Integrated toast management and new in-game notifications with an app status bar.

src/client/java/minicraft/screen/AchievementsDisplay.java

src/client/java/minicraft/core/Renderer.java

src/client/java/minicraft/screen/AppToast.java

Makkkkus · 2025-06-11T19:49:35Z

src/client/java/minicraft/screen/Toast.java

+	protected int tick = 0;
+	protected int animationTick = 0; // 0 to ANIMATION_TIME, ANIMATION_TIME to 0
+
+	protected static abstract class ToastFrame {


Please remove the ToastFrame class as it is a single-variable class with no functionality that cannot be done in the Toast class. There is no need to create classes just for the fun of it.

src/client/java/minicraft/core/Renderer.java

Makkkkus · 2025-06-12T21:17:14Z

src/client/java/minicraft/core/Renderer.java


+	public static final AppStatusBar appStatusBar = new AppStatusBar();
+
+	public static class AppStatusBar {


Perhaps move the AppStatusBar and it's implementations into it's own file?

And variables are usually declared at the top of the class.

I am not so sure about this since it is only used in Renderer and (ticked by) Updater.

Makkkkus · 2025-06-12T21:26:50Z

src/client/java/minicraft/core/Renderer.java

+				this.status = status;
+			}
+		}
+	}


I think AppStatusBar, AppStatusElement and HardwareAccelerationElementStatus are similar enough to to be merged as a single class (similar to how the holding item bar at the bottom of the screen works).

Looking at how HARDWARE_ACCELERATION_STATUS is declared on the parent of the object it references, it would make more sense to create a struct with the data you want each icon to have, and then create instances of that struct when adding a new icon.

Blinking and all of that can be implemented in AppStatusBar, negating the need to call any other class. And System.getProperty("sun.java2d.opengl") doesn't necessarily need to be cached.

I am not sure why you meant they are similar. Anyway, looking at this implementation is not sufficient. As an example, #588 added 2 new icons with more complex implementation details than this one.

Blinking is meaningful only for a particular one icon, thus not responsible for AppStatusBar to implement.

I'm proposing to move all functionality of this into the AppStatusBar class. Bringing in other pull requests into this is irrelevant.

Anything can be implemented in AppStatusBar, it's just a question if you are willing to cooperate and do such. Look at how other similar features are implemented (that you haven't designed).

Makkkkus · 2025-06-12T21:37:36Z

src/client/java/minicraft/screen/Toast.java

+	protected int tick = 0;
+	protected int animationTick = 0; // 0 to ANIMATION_TIME, ANIMATION_TIME to 0
+
+	protected static abstract class ToastFrame {


Makkkkus · 2025-06-15T20:27:38Z

src/client/java/minicraft/core/Renderer.java

 		}

-		public abstract class AppStatusElement {
+		public enum GeneralStatus {


This can be a boolean.

Makkkkus

I'm very dissapointed with these changes.

Makkkkus · 2025-06-15T20:29:48Z

src/client/java/minicraft/core/Renderer.java

-
-			@MagicConstant(intValues = {ACCELERATION_ON, ACCELERATION_OFF})
-			private int status = ACCELERATION_ON;
+		public class HardwareAccelerationElementStatus extends AppStatusElement<GeneralStatus> {


Please remove this class.

Makkkkus · 2025-06-15T20:30:02Z

src/client/java/minicraft/core/Renderer.java

+			OFF, ON
+		}
+
+		public abstract class AppStatusElement<E extends Enum<E>> {


Please remove this class. It serves no purpose.

Please check further implementation than just a single usage with a minimal usage pattern. This API is designed to be extensible.

We don't know if this will be extended yet. Minimal implementation is fine for most uses.

Still, this is a part of this API design.

If this will not be extended, it is whole pointless to add this API; I would rather remove this feature from this pull request.

Removed App Status Bar; #588 will be broken.

Makkkkus · 2025-06-15T20:30:25Z

src/client/java/minicraft/screen/GameToast.java

+ * Game Toasts are rendered only in gameplay and always located in the top-left corner without margin.
+ * The content of game toasts is implementation-specific.
+ */
+public abstract class GameToast extends Toast {


Why did you add this class??

To constrain and categorize to have only game toasts and app toasts more exactly. In design, it is not expected to see app toasts being in the list of game toasts, and game toasts are expected to behave similarly, different from app toasts in certain aspects.

We already discussed this. You removed it. And now you're adding it back? Adding it is just a way of writing more code that does less. Adding code for the sake of adding code is pointless.

I have not removed it, but ignored it from the implementation to simplify the structure (in fact it should be specialized for the API). Also, adding design constrains preventing unexpected behaviors is an important thing for designing API.

Good this is a game and not an API then

Add support for in-app notifications

dd22210

BenCheung0422 force-pushed the notification branch from 36ab19c to dd22210 Compare November 15, 2023 11:03

BenCheung0422 mentioned this pull request Nov 19, 2023

Update controller code for key detection and add setting for controller enablement #588

Draft

Change notification max width to half of screen

b9879e4

BenCheung0422 added 2 commits February 9, 2024 05:41

Merge remote-tracking branch 'upstream/main' into notification

939c80a

# Conflicts: # src/client/java/minicraft/item/FishingRodItem.java # src/client/java/minicraft/item/SummonItem.java # src/client/java/minicraft/screen/AchievementsDisplay.java

Add AppToast in place of Notification

beb692b

BenCheung0422 added 2 commits February 9, 2024 17:36

Add AppStatusBar

5cc2168

Add Achievement Toast in place of notifications

1b7a424

BenCheung0422 changed the title ~~Add support for in-app notifications~~ Improved supports for in-app/game notifications and toasts Feb 9, 2024

Renderer AppStatusBar add missing tick method

9e5d104

Makkkkus requested changes Feb 12, 2024

View reviewed changes

Remove GameToast

c491dad

Litorom and others added 2 commits February 13, 2024 09:21

Merge branch 'main' into notification

2c5840d

Change hot key to show status bar to back quote

e962b57

BenCheung0422 mentioned this pull request Apr 11, 2024

Simplify screenshot feature #660

Merged

Merge remote-tracking branch 'upstream/main' into notification

519cb28

# Conflicts: # src/client/java/minicraft/core/Renderer.java # src/client/java/minicraft/screen/TutorialDisplayHandler.java

Litorom and others added 2 commits June 27, 2024 17:00

Merge branch 'main' into notification

df55f94

Merge remote-tracking branch 'upstream/main' into notification

5005995

# Conflicts: # src/client/java/minicraft/entity/furniture/DeathChest.java

BenCheung0422 added UX labels Aug 28, 2024

BenCheung0422 added User awareness labels Aug 28, 2024

Makkkkus removed Rendering labels Dec 5, 2024

BenCheung0422 mentioned this pull request Dec 9, 2024

Improved supports for in-app/game notifications and toasts bitsusei/TerraModulus#9

Merged

Makkkkus requested changes Jun 3, 2025

View reviewed changes

ChristofferHolmesland requested a review from Copilot June 3, 2025 14:23

Copilot AI reviewed Jun 3, 2025

View reviewed changes

src/client/java/minicraft/screen/AchievementsDisplay.java Show resolved Hide resolved

BenCheung0422 added 2 commits June 4, 2025 00:50

Toasts: Fixed requested changes from reviews

f1e0a98

Toasts: Fixed requested changes from reviews

7673221

Makkkkus reviewed Jun 8, 2025

View reviewed changes

src/client/java/minicraft/core/Renderer.java Outdated Show resolved Hide resolved

Makkkkus requested changes Jun 11, 2025

View reviewed changes

Makkkkus requested changes Jun 12, 2025

View reviewed changes

Toasts: Refactor structures

5fce00e

BenCheung0422 force-pushed the notification branch from 353e26e to 5fce00e Compare June 13, 2025 16:43

Makkkkus reviewed Jun 15, 2025

View reviewed changes

Makkkkus requested changes Jun 15, 2025

View reviewed changes

Revert addition of AppStatusBar

7323f26


		public static final AppStatusBar appStatusBar = new AppStatusBar();

		public static class AppStatusBar {

Improved supports for in-app/game notifications and toasts #587

Are you sure you want to change the base?

Improved supports for in-app/game notifications and toasts #587

Uh oh!

Conversation

BenCheung0422 commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenCheung0422 commented Dec 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Makkkkus commented Jan 7, 2024

Uh oh!

BenCheung0422 commented Feb 9, 2024

Uh oh!

BenCheung0422 commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenCheung0422 commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenCheung0422 commented Feb 9, 2024

Uh oh!

Makkkkus left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenCheung0422 commented Feb 13, 2024

Uh oh!

Litorom commented Jun 25, 2024

Uh oh!

BenCheung0422 commented Jun 25, 2024

Uh oh!

Makkkkus commented Jun 3, 2025

Uh oh!

BenCheung0422 commented Jun 3, 2025

Uh oh!

Makkkkus commented Jun 3, 2025

Uh oh!

Makkkkus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Makkkkus Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenCheung0422 Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenCheung0422 commented Nov 15, 2023 •

edited

Loading

BenCheung0422 commented Dec 30, 2023 •

edited

Loading

BenCheung0422 commented Feb 9, 2024 •

edited

Loading

BenCheung0422 commented Feb 9, 2024 •

edited

Loading

Makkkkus left a comment •

edited

Loading

Makkkkus Jun 11, 2025 •

edited

Loading

BenCheung0422 Jun 13, 2025 •

edited

Loading

BenCheung0422 Jun 16, 2025 •

edited

Loading