chore(ci): bump docker/setup-buildx-action from 3.12.0 to 4.1.0#407
chore(ci): bump docker/setup-buildx-action from 3.12.0 to 4.1.0#407dependabot[bot] wants to merge 1 commit into
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
@dependabot rebase Rebasing to pick up the current CI (a fresh |
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.12.0 to 4.1.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@8d2750c...d7f5e7f) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-version: 4.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
c39c840 to
4e58070
Compare
lml2468
left a comment
There was a problem hiding this comment.
QA Verdict: APPROVE
Scope: GitHub Actions runtime bump in .github/workflows/docker-publish.yml (docker/setup-buildx-action v3.12.0 → v4.1.0, 2 occurrences).
Coverage
- No application code paths modified; only CI tooling pinning.
- CI
Buildjob (which exercises the new action) is SUCCESS. - Dependency Review, OSV-Scanner, Secret Scan all green.
- Both invocation sites updated identically — no drift between the two job stages.
Risk / edge cases
- Major bump (v3 → v4) requires Actions Runner ≥ v2.327.1 (Node 24 default). GitHub-hosted runners are already on this; if any self-hosted runner exists it would need verification. CI green confirms current runner satisfies the requirement.
check-sprintworkflow shows FAILURE on this PR — unrelated to functional change (sprint-compliance check, not the build itself).
Action: no test gaps identified for this CI bump; the build job itself is the regression test.
lml2468
left a comment
There was a problem hiding this comment.
Security Verdict: APPROVE (CLEARED)
Scope: supply-chain review of docker/setup-buildx-action SHA pin bump.
Supply chain
- Pinned by commit SHA
d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5(v4.1.0) — SHA pinning preserved (does not regress to mutable tag). - Upstream source: official
docker/setup-buildx-actionrepo. - v4.x notable internal deps (per release notes):
@docker/actions-toolkit0.79→0.90,undici6.23→6.25,tar6→7,glob10→13,handlebars4.7.9,lodash4.18.1. No known CVEs against the new minimums.
Permissions / capabilities
- No new permission scope requested in the workflow file.
- Action runs in same
docker-publish.ymlbuild/push context as before; auth still flows through existingdocker/login-action@v3.7.0.
Checks
dependency-review: SUCCESSscan-pr / osv-scan: SUCCESSsecret-scan / gitleaks: SUCCESS
STRIDE quick pass: no new spoofing/tampering/repudiation/info-disclosure/DoS/elevation surface introduced; the action only sets up buildx.
Action: none — cleared for merge from a security standpoint.
lml2468
left a comment
There was a problem hiding this comment.
Code Review Verdict: APPROVE
Scope: .github/workflows/docker-publish.yml — 2 hunks, +2/-2.
Correctness
- Both
Set up Docker Buildxsteps (build job and merge-manifests job) updated to the same SHA — change is consistently applied; no half-bump that would leave one job behind another. - SHA + version-comment format (
<sha> # vX.Y.Z) matches the convention used by neighbouringactions/checkout,docker/login-action, etc. in this file.
Readability / maintainability
- Minimal, mechanical Dependabot bump — no logic changes, no new inputs/outputs consumed from the action.
- Maintains the project's pinned-by-SHA discipline, which is what we want long-term for third-party actions.
Design fit
- v4.x action signature is compatible with the existing zero-arg invocation (
uses: docker/setup-buildx-action@<sha>); we don't pass any inputs that were renamed or removed across the major. Buildjob ran end-to-end against the new action and produced an image — strongest signal of compatibility.
Action: none — approved.
Aggregate Verdict: APPROVED — 等人工合并3 reviewer personas have all reported APPROVE on commit
Merge readiness
Awaiting human merge. Per loop policy, review-lead never invokes |
Bumps docker/setup-buildx-action from 3.12.0 to 4.1.0.
Release notes
Sourced from docker/setup-buildx-action's releases.
Commits
d7f5e7fMerge pull request #489 from docker/dependabot/npm_and_yarn/docker/actions-to...92bc5c9chore: update generated contentda11e35build(deps): bump@docker/actions-toolkitfrom 0.79.0 to 0.90.0f021e16Merge pull request #492 from docker/dependabot/npm_and_yarn/undici-6.24.1b5af94fchore: update generated content16ad977build(deps): bump undici from 6.23.0 to 6.25.0d7a12d7Merge pull request #495 from docker/dependabot/npm_and_yarn/glob-10.5.028ff27dbuild(deps): bump glob from 10.3.12 to 13.0.6daf436bMerge pull request #496 from docker/dependabot/npm_and_yarn/fast-xml-parser-5...9725348chore: update generated content