Skip to content

chore(ci): bump docker/setup-buildx-action from 3.12.0 to 4.1.0#407

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/docker/setup-buildx-action-4.1.0
Open

chore(ci): bump docker/setup-buildx-action from 3.12.0 to 4.1.0#407
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/docker/setup-buildx-action-4.1.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 16, 2026

Copy link
Copy Markdown

Bumps docker/setup-buildx-action from 3.12.0 to 4.1.0.

Release notes

Sourced from docker/setup-buildx-action's releases.

v4.1.0

Full Changelog: docker/setup-buildx-action@v4.0.0...v4.1.0

v4.0.0

Full Changelog: docker/setup-buildx-action@v3.12.0...v4.0.0

Commits
  • d7f5e7f Merge pull request #489 from docker/dependabot/npm_and_yarn/docker/actions-to...
  • 92bc5c9 chore: update generated content
  • da11e35 build(deps): bump @​docker/actions-toolkit from 0.79.0 to 0.90.0
  • f021e16 Merge pull request #492 from docker/dependabot/npm_and_yarn/undici-6.24.1
  • b5af94f chore: update generated content
  • 16ad977 build(deps): bump undici from 6.23.0 to 6.25.0
  • d7a12d7 Merge pull request #495 from docker/dependabot/npm_and_yarn/glob-10.5.0
  • 28ff27d build(deps): bump glob from 10.3.12 to 13.0.6
  • daf436b Merge pull request #496 from docker/dependabot/npm_and_yarn/fast-xml-parser-5...
  • 9725348 chore: update generated content
  • Additional commits viewable in compare view

@dependabot @github

dependabot Bot commented on behalf of github Jun 16, 2026

Copy link
Copy Markdown
Author

Labels

The following labels could not be found: dependencies, github-actions. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot Bot requested a review from a team as a code owner June 16, 2026 05:44
@github-actions github-actions Bot added the size/XS PR size: XS label Jun 16, 2026
@lml2468

lml2468 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@dependabot rebase

Rebasing to pick up the current CI (a fresh Build + code-review run). With the review gate now at 1 approval, these CI-action bumps can merge once checks are green. — automated PR-review cadence (OCT-13)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.12.0 to 4.1.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@8d2750c...d7f5e7f)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-version: 4.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/github_actions/docker/setup-buildx-action-4.1.0 branch from c39c840 to 4e58070 Compare June 17, 2026 16:19
@lml2468 lml2468 added review:running:qa qa-engineer review in progress review:running:security security-engineer review in progress review:running:code code-reviewer review in progress labels Jun 27, 2026

@lml2468 lml2468 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Verdict: APPROVE

Scope: GitHub Actions runtime bump in .github/workflows/docker-publish.yml (docker/setup-buildx-action v3.12.0 → v4.1.0, 2 occurrences).

Coverage

  • No application code paths modified; only CI tooling pinning.
  • CI Build job (which exercises the new action) is SUCCESS.
  • Dependency Review, OSV-Scanner, Secret Scan all green.
  • Both invocation sites updated identically — no drift between the two job stages.

Risk / edge cases

  • Major bump (v3 → v4) requires Actions Runner ≥ v2.327.1 (Node 24 default). GitHub-hosted runners are already on this; if any self-hosted runner exists it would need verification. CI green confirms current runner satisfies the requirement.
  • check-sprint workflow shows FAILURE on this PR — unrelated to functional change (sprint-compliance check, not the build itself).

Action: no test gaps identified for this CI bump; the build job itself is the regression test.

@lml2468 lml2468 added review:done:qa:approve qa-engineer PASS and removed review:running:qa qa-engineer review in progress labels Jun 27, 2026

@lml2468 lml2468 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Verdict: APPROVE (CLEARED)

Scope: supply-chain review of docker/setup-buildx-action SHA pin bump.

Supply chain

  • Pinned by commit SHA d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5 (v4.1.0) — SHA pinning preserved (does not regress to mutable tag).
  • Upstream source: official docker/setup-buildx-action repo.
  • v4.x notable internal deps (per release notes): @docker/actions-toolkit 0.79→0.90, undici 6.23→6.25, tar 6→7, glob 10→13, handlebars 4.7.9, lodash 4.18.1. No known CVEs against the new minimums.

Permissions / capabilities

  • No new permission scope requested in the workflow file.
  • Action runs in same docker-publish.yml build/push context as before; auth still flows through existing docker/login-action@v3.7.0.

Checks

  • dependency-review: SUCCESS
  • scan-pr / osv-scan: SUCCESS
  • secret-scan / gitleaks: SUCCESS

STRIDE quick pass: no new spoofing/tampering/repudiation/info-disclosure/DoS/elevation surface introduced; the action only sets up buildx.

Action: none — cleared for merge from a security standpoint.

@lml2468 lml2468 added review:done:security:approve security-engineer CLEARED and removed review:running:security security-engineer review in progress labels Jun 27, 2026

@lml2468 lml2468 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Verdict: APPROVE

Scope: .github/workflows/docker-publish.yml — 2 hunks, +2/-2.

Correctness

  • Both Set up Docker Buildx steps (build job and merge-manifests job) updated to the same SHA — change is consistently applied; no half-bump that would leave one job behind another.
  • SHA + version-comment format (<sha> # vX.Y.Z) matches the convention used by neighbouring actions/checkout, docker/login-action, etc. in this file.

Readability / maintainability

  • Minimal, mechanical Dependabot bump — no logic changes, no new inputs/outputs consumed from the action.
  • Maintains the project's pinned-by-SHA discipline, which is what we want long-term for third-party actions.

Design fit

  • v4.x action signature is compatible with the existing zero-arg invocation (uses: docker/setup-buildx-action@<sha>); we don't pass any inputs that were renamed or removed across the major.
  • Build job ran end-to-end against the new action and produced an image — strongest signal of compatibility.

Action: none — approved.

@lml2468 lml2468 added review:done:code:approve code-reviewer APPROVED and removed review:running:code code-reviewer review in progress labels Jun 27, 2026
@lml2468

lml2468 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Aggregate Verdict: APPROVED — 等人工合并

3 reviewer personas have all reported APPROVE on commit 4e58070. No blocking findings.

Reviewer Verdict Summary
qa-engineer ✅ APPROVE CI Build SUCCESS; no app code paths touched — the workflow run itself is the regression test. check-sprint FAILURE is unrelated (sprint-compliance, not the build).
security-engineer ✅ APPROVE (CLEARED) SHA pinning preserved (d7f5e7f…); upstream is official docker/setup-buildx-action; no new permission scope; dependency-review / OSV / gitleaks all green.
code-reviewer ✅ APPROVE Both invocation sites (build + merge-manifests) updated to the same SHA; matches repo's <sha> # vX.Y.Z pinning convention; v4 action signature compatible with existing zero-arg usage.

Merge readiness

  • mergeable: MERGEABLE, mergeStateStatus: UNSTABLE (caused only by the unrelated check-sprint workflow — flagged for human awareness, not blocking).
  • Major version bump (v3 → v4) requires Actions Runner ≥ v2.327.1 (Node 24); GitHub-hosted runners already satisfy this and the Build job exercising the new action passed end-to-end.

Awaiting human merge. Per loop policy, review-lead never invokes gh pr merge.

@lml2468 lml2468 added the review:complete 3 verdicts aggregated, awaiting human merge label Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:complete 3 verdicts aggregated, awaiting human merge review:done:code:approve code-reviewer APPROVED review:done:qa:approve qa-engineer PASS review:done:security:approve security-engineer CLEARED size/XS PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant