vector_vendor: checked-in binary, no network fetch - #429
Closed
Minipada wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jazzy #429 +/- ##
=======================================
Coverage 70.93% 70.93%
=======================================
Files 119 119
Lines 7401 7401
=======================================
Hits 5249 5249
Misses 2152 2152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Minipada
force-pushed
the
feature/424-vector-vendor-checked-in-binary-no-netwo
branch
2 times, most recently
from
August 27, 2026 18:04
a0d0c72 to
a843864
Compare
… fetch Replace vector_vendor's file(DOWNLOAD ...) with the official Vector 0.57.0 release tarballs (x86_64 + aarch64, same bytes/checksums already pinned) checked into vector_vendor/prebuilt/. CMakeLists.txt now extracts and installs from the local file instead of fetching it over the network, so colcon build --packages-select vector_vendor succeeds under #423's --network=none harness. Not Git LFS: evaluated and briefly adopted mid-review after verifying (by tracing and empirically testing the actual bloom/vcstools release code) that LFS content does survive bloom's release-tarball export step, contrary to #421's original assumption. Reverted anyway for a simpler reason: GitHub's free LFS tier is 1GB storage/month, and each future Vector bump would add ~106MB of new, non-deduplicated LFS objects -- about 9 bumps before hitting that ceiling. A plain committed blob has no such quota; the tradeoff is ordinary git history growing by the same ~106MB per bump instead. See ADR-0002's amendment for the full reasoning and the LFS trace, kept for the record in case LFS needs revisiting later. Closes #424 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019hV3DGw8o1QKsYbo8fQaS9 Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
Minipada
force-pushed
the
feature/424-vector-vendor-checked-in-binary-no-netwo
branch
from
August 28, 2026 00:24
a843864 to
ec17da8
Compare
This was referenced Aug 28, 2026
Owner
Author
Minipada
deleted the
feature/424-vector-vendor-checked-in-binary-no-netwo
branch
August 28, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vector_vendor'sfile(DOWNLOAD ...)with the official Vector 0.57.0 release tarballs (x86_64 + aarch64) checked intovector_vendor/prebuilt/as plain committed blobs — same bytes, same SHA256 checksums already pinned inCMakeLists.txt.CMakeLists.txtnow extracts and installs the Vector binary from the local checked-in tarball; no network access at build time.vector_path/VECTOR_PATHoverride is unchanged.bloom's release-tarball export step) doesn't actually hold — traced and empirically tested the realbloom/vcstoolscode, which does correctly smudge/archive real LFS content. LFS was reverted anyway for a simpler reason: GitHub's free LFS tier is 1GB/month, and each future Vector version bump would add ~106MB of new, non-deduplicated LFS objects — about 9 bumps before hitting that ceiling. A plain committed blob has no such quota; the tradeoff is the same ~106MB added to ordinary git history per bump instead. ADR-0002 documents both the trace (kept for the record) and the final call..pre-commit-config.yaml: scoped exclude oncheck-added-large-filesfor the two tarballs (2MB default cap, by design).REUSE.toml: license annotation for the vendored tarballs (MPL-2.0, Vector Authors).Test plan
git add -A && prek run --all-files --skip build-docpasses (REUSE, large-file, format checks all green)./tools/e2e/scripts/verify_network_isolation.sh(Network-isolated build verification harness for vendor packages #423's harness):colcon build --packages-select aws_sdk_vendor vector_vendorunder--network=noneshowsFinished <<< vector_vendor— vector_vendor builds with zero network access.aws_sdk_vendorstill fails on its git clone as expected (tracked separately by aws_sdk_vendor: flattened source, no network fetch #425);network-isolation-checkinci.yamlstaysif: falseuntil that lands too.CMakeLists.txt.build-workspacejob) before the LFS revert — full workspace build + colcon test passed buildingvector_vendorfrom the checked-in file. One unrelated flaky test (MeasurementMissionOpenRmfTest, a pre-existingdc_measurementslifecycle-node race, reproduced identically onjazzy's own last green commit) passed cleanly on rerun with zero code changes.Closes #424
🤖 Generated with Claude Code
https://claude.ai/code/session_019hV3DGw8o1QKsYbo8fQaS9