Update balance.py #28
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added functionality to switch suggested players by default and have both !veto the switch or an admin !dont it. Controlled by cvar qlx_balanceSwitchOptIn
Collaborator
|
Hi, @mgaertne! Also, it would be good, to add documentation on this cvar after approving cvar name. |
em92
reviewed
Jul 20, 2021
Comment on lines
512
to
+519
| """Forces a suggested switch to be done.""" | ||
| if self.suggested_pair: | ||
| self.execute_suggestion() | ||
| if not self.suggested_pair: | ||
| return | ||
|
|
||
| if not self.switch_opt_in: | ||
| return | ||
|
|
||
| self.execute_suggestion() |
Collaborator
There was a problem hiding this comment.
Player joins on round countdown, script notices that next round switch will be executed, admin wants to execute it right now, types "!do" and says "wtf?".
Not to have this situation, I suggest to return previous version of cmd_do
em92
reviewed
Jul 20, 2021
Comment on lines
-505
to
+536
| if self.suggested_pair and not all(self.suggested_agree): | ||
| p1, p2 = self.suggested_pair | ||
| if not self.suggested_pair or not self.switch_opt_in or all(self.suggested_agree): | ||
| return |
Collaborator
There was a problem hiding this comment.
I would move swtich_opt_in checking to top of cmd_agree function. To indicate that this command is not used on auto switch enabled.
em92
reviewed
Jul 20, 2021
Comment on lines
+558
to
+559
| if not self.suggested_pair or self.switch_opt_in: | ||
| return |
Collaborator
There was a problem hiding this comment.
Contributor
Author
|
Heya Eugene,
I later found a problem in the code resulting in no switches. I will have
to work this over a bit more. qlx_balanceAutoSwitch sounds good.
Best
ShiN0
…On Tue, Jul 20, 2021 at 10:31 AM Eugene Molotov ***@***.***> wrote:
Hi, @mgaertne <https://github.com/mgaertne>!
Name of cvar "qlx_balanceSwitchOptIn" is confusing. How about naming it as
qlx_balanceAutoSwitch?
Also, it would be good, to add documentation on this cvar after approving
cvar name.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALXQBHNL4Z5XQAN5M3DPTTYUX7RANCNFSM5AEDWDJA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added functionality to switch suggested players by default and have both !veto the switch or an admin !dont it. Controlled by cvar qlx_balanceSwitchOptIn